Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2680423003: Reduce namespaces for ash::launcher::AppLauncherId (Closed)

Created:
3 years, 10 months ago by khmel
Modified:
3 years, 10 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, tfarina, msw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce namespaces for ash::launcher::AppLauncherId BUG=689772 TEST=git cl try Review-Url: https://codereview.chromium.org/2680423003 Cr-Commit-Position: refs/heads/master@{#449324} Committed: https://chromium.googlesource.com/chromium/src/+/fdf3c8882b164d5bc70bc52776bdade079dfefe5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -53 lines) Patch
M chrome/browser/ui/ash/app_launcher_id.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/app_launcher_id.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 10 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 10 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_controller_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_controller_helper.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_item_controller.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
khmel
Hi James, As you suggested, we remove launcher namespace from AppLauncherId. PTAL Thanks
3 years, 10 months ago (2017-02-09 15:40:09 UTC) #6
James Cook
LGTM. Thanks for taking care of this.
3 years, 10 months ago (2017-02-09 16:51:43 UTC) #7
James Cook
cc msw as fyi
3 years, 10 months ago (2017-02-09 16:52:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680423003/1
3 years, 10 months ago (2017-02-09 16:52:28 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 16:59:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdf3c8882b164d5bc70bc52776bd...

Powered by Google App Engine
This is Rietveld 408576698