Update SupportsUserData API to accept std::unique_ptr<>.

Update SupportsUserData API to accept std::unique_ptr<>.

SupportsUserData takes ownership of the SupportsUserData::Data
passed to SetUserData. Add an overload taking a std::unique_ptr
so that client code can be converted incrementally.

BUG=690937
Review-Url: https://codereview.chromium.org/2680403004
Cr-Commit-Position: refs/heads/master@{#449933}
Committed: https://chromium.googlesource.com/chromium/src/+/ae5e2d28e5254462e5e5d973b788a574b3053b8f

[sdefresne, 2017-02-10 10:52:22]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2017-02-10 10:52:23]

Please take a look.

I know that the style guide recommends against using overloads, but I think this
one is okay as the parameters types are incompatible (there is no implicit
conversion from Data* to std::unique_ptr<Data>) and the call can be easily
distinguished.

[sdefresne, 2017-02-10 10:52:27]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 10:52:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-10 15:04:23]

if you're planning to do some big change incrementally, please have a tracking
bug for that change and use it in the BUG= line for all the changes related to
it

[sdefresne, 2017-02-10 15:07:48]

Description was changed from

==========
Update SupportsUserData API to accept std::unique_ptr<>.

SupportsUserData takes ownership of the SupportsUserData::Data
passed to SetUserData. Add an overload taking a std::unique_ptr
so that client code can be converted incrementally.

BUG=None
==========

to

==========
Update SupportsUserData API to accept std::unique_ptr<>.

SupportsUserData takes ownership of the SupportsUserData::Data
passed to SetUserData. Add an overload taking a std::unique_ptr
so that client code can be converted incrementally.

BUG=690937
==========

[sdefresne, 2017-02-10 15:07:57]

Done => https://bugs.chromium.org/p/chromium/issues/detail?id=690937.

[commit-bot: I haz the power, 2017-02-10 15:36:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 15:36:52]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-02-10 17:54:25]

lgtm, thanks

https://codereview.chromium.org/2680403004/diff/1/base/supports_user_data.h
File base/supports_user_data.h (right):

https://codereview.chromium.org/2680403004/diff/1/base/supports_user_data.h#n...
base/supports_user_data.h:41: void SetUserData(const void* key, Data* data);
add a "// TODO: remove the raw ptr version once everything uses the unique_ptr
version, crbug.com/$your_bug"

[sdefresne, 2017-02-13 10:09:12]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-02-13 10:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2680403004/#ps20001
(title: "Add TODO.")

[commit-bot: I haz the power, 2017-02-13 10:09:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 11:49:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486980552011730,
"parent_rev": "128197bbfc8d38eae9adf1f2e766683301c80097", "commit_rev":
"ae5e2d28e5254462e5e5d973b788a574b3053b8f"}

[commit-bot: I haz the power, 2017-02-13 11:50:06]

Description was changed from

==========
Update SupportsUserData API to accept std::unique_ptr<>.

SupportsUserData takes ownership of the SupportsUserData::Data
passed to SetUserData. Add an overload taking a std::unique_ptr
so that client code can be converted incrementally.

BUG=690937
==========

to

==========
Update SupportsUserData API to accept std::unique_ptr<>.

SupportsUserData takes ownership of the SupportsUserData::Data
passed to SetUserData. Add an overload taking a std::unique_ptr
so that client code can be converted incrementally.

BUG=690937

Review-Url: https://codereview.chromium.org/2680403004
Cr-Commit-Position: refs/heads/master@{#449933}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae5e2d28e5254462e5e5d973b788...
==========

[commit-bot: I haz the power, 2017-02-13 11:50:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae5e2d28e5254462e5e5d973b788...