Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2680403003: [ObjC ARC] Converts ios/chrome/browser/ui/settings/utils:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/settings/utils:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2680403003 Cr-Commit-Position: refs/heads/master@{#449593} Committed: https://chromium.googlesource.com/chromium/src/+/12909f0790e370d24643c6f93213f1cf29cfeb8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M ios/chrome/browser/ui/settings/utils/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/settings/utils/content_setting_backed_boolean_unittest.mm View 5 chunks +16 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm View 5 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lody
Please review, thank you
3 years, 10 months ago (2017-02-10 09:10:24 UTC) #6
sdefresne
lgtm
3 years, 10 months ago (2017-02-10 10:20:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680403003/1
3 years, 10 months ago (2017-02-10 12:02:52 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 12:08:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/12909f0790e370d24643c6f93213...

Powered by Google App Engine
This is Rietveld 408576698