Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2680393003: Preliminary refactoring to improve test expectation specifiers added by importer. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preliminary refactoring to improve test expectation specifiers added by importer. This change includes clean-up and refactoring in wpt_expectations_updater without actually changing its behavior. BUG=655201 Review-Url: https://codereview.chromium.org/2680393003 Cr-Commit-Position: refs/heads/master@{#449350} Committed: https://chromium.googlesource.com/chromium/src/+/a0c9d2388e2ad1d6e500befba0aa38af5bb4e9cb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -92 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py View 1 3 chunks +31 lines, -31 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py View 23 chunks +84 lines, -61 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
3 years, 10 months ago (2017-02-09 00:45:49 UTC) #2
jeffcarp
lgtm https://codereview.chromium.org/2680393003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py (right): https://codereview.chromium.org/2680393003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py#newcode112 third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py:112: full_port_name: The full-qualified port name, e.g. "win-win10". Should ...
3 years, 10 months ago (2017-02-09 00:50:17 UTC) #5
qyearsley
https://codereview.chromium.org/2680393003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py (right): https://codereview.chromium.org/2680393003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py#newcode112 third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py:112: full_port_name: The full-qualified port name, e.g. "win-win10". On 2017/02/09 ...
3 years, 10 months ago (2017-02-09 17:01:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680393003/20001
3 years, 10 months ago (2017-02-09 17:03:10 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 18:11:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a0c9d2388e2ad1d6e500befba0aa...

Powered by Google App Engine
This is Rietveld 408576698