Created skeleton for switch access component extension.

Created skeleton for switch access component extension.

If you run Chrome with the --enable-experimental-accessibility-features flag,
then toggling the Switch access checkbox in the accessibility settings loads
or unloads this component extension. This can be verified by inspecting the
extension at chrome://inspect and seeing that switch_access.js logged to the
background console.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2680383002
Cr-Commit-Position: refs/heads/master@{#451915}
Committed: https://chromium.googlesource.com/chromium/src/+/0746c1bd31524520714d53ab8e9f593730efa78a

[elichtenberg, 2017-02-08 20:45:18]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
switch_access_skeleton


Implemented switch access skeleton

BUG=
==========

to

==========
Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
switch_access_skeleton


Implemented switch access skeleton

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-02-08 20:48:00]

elichtenberg@google.com changed reviewers:
+ dmazzoni@chromium.org

[elichtenberg, 2017-02-08 20:48:47]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 20:49:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:15:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:15:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-02-09 00:16:04]

Please edit the description and get rid of extra notes like merging, etc.

in Chrome all of your git commits get "squashed", so use "git cl description" or
edit the description online.

Use BUG=593885 for all of your changes unless you want to file bugs for specific
features. In general we like to associate every changelist with a bug, but
multiple changelists for the same bug is fine.

Finally I see some test failures from try bots, so click on those and
see what's going on.

I'll also look through the code and see if anything else jumps out.

[elichtenberg, 2017-02-09 17:48:48]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
switch_access_skeleton


Implemented switch access skeleton

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Created skeleton for switch access component extension.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-02-09 17:55:52]

Description was changed from

==========
Created skeleton for switch access component extension.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Created skeleton for switch access component extension.

If you run Chrome with the --enable-experimental-accessibility-features flag,
then toggling the Switch access checkbox in the accessibility settings loads
or unloads this component extension. This can be verified by inspecting the
extension at chrome://inspect and seeing that switch_access.js logged to the
background console.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-02-09 18:02:49]

Description was changed from

==========
Created skeleton for switch access component extension.

If you run Chrome with the --enable-experimental-accessibility-features flag,
then toggling the Switch access checkbox in the accessibility settings loads
or unloads this component extension. This can be verified by inspecting the
extension at chrome://inspect and seeing that switch_access.js logged to the
background console.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Created skeleton for switch access component extension.

If you run Chrome with the --enable-experimental-accessibility-features flag,
then toggling the Switch access checkbox in the accessibility settings loads
or unloads this component extension. This can be verified by inspecting the
extension at chrome://inspect and seeing that switch_access.js logged to the
background console.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-02-09 18:03:13]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 18:03:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 19:09:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 19:09:51]

Dry run: This issue passed the CQ dry run.

[elichtenberg, 2017-02-09 19:14:13]

On 2017/02/09 00:16:04, dmazzoni wrote:
> Please edit the description and get rid of extra notes like merging, etc.
> 
> in Chrome all of your git commits get "squashed", so use "git cl description"
or
> edit the description online.
> 
> Use BUG=593885 for all of your changes unless you want to file bugs for
specific
> features. In general we like to associate every changelist with a bug, but
> multiple changelists for the same bug is fine.
> 
> Finally I see some test failures from try bots, so click on those and
> see what's going on.
> 
> I'll also look through the code and see if anything else jumps out.

Done. All tests passing now.

[dmazzoni, 2017-02-09 19:22:51]

dmazzoni@chromium.org changed reviewers:
+ rockot@chromium.org

[dmazzoni, 2017-02-09 19:22:52]

lgtm

+rockot for OWNERS approval of *extensions*

https://codereview.chromium.org/2680383002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/switch_access/BUILD.gn (right):

https://codereview.chromium.org/2680383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/BUILD.gn:1: # Copyright 2016 The
Chromium Authors. All rights reserved.
Update to 2017

https://codereview.chromium.org/2680383002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/switch_access/switch_access.js (right):

https://codereview.chromium.org/2680383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/switch_access.js:1: // Copyright
2016 The Chromium Authors. All rights reserved.
2017

[Ken Rockot(use gerrit already), 2017-02-10 03:42:13]

rs lgtm

[elichtenberg, 2017-02-10 19:26:44]

The CQ bit was checked by elichtenberg@google.com

[commit-bot: I haz the power, 2017-02-10 19:27:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 19:41:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[elichtenberg, 2017-02-10 23:40:06]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 23:40:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 00:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 00:13:50]

Dry run: This issue passed the CQ dry run.

[elichtenberg, 2017-02-11 00:14:45]

The CQ bit was checked by elichtenberg@google.com

[commit-bot: I haz the power, 2017-02-11 00:15:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 00:23:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 00:23:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[elichtenberg, 2017-02-11 00:36:59]

https://codereview.chromium.org/2680383002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/switch_access/BUILD.gn (right):

https://codereview.chromium.org/2680383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/BUILD.gn:1: # Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/02/09 19:22:52, dmazzoni wrote:
> Update to 2017

Done.

https://codereview.chromium.org/2680383002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/switch_access/switch_access.js (right):

https://codereview.chromium.org/2680383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/switch_access.js:1: // Copyright
2016 The Chromium Authors. All rights reserved.
On 2017/02/09 19:22:52, dmazzoni wrote:
> 2017

Done.

[dmazzoni, 2017-02-15 22:49:18]

dmazzoni@chromium.org changed reviewers:
+ brettw@chromium.org

[dmazzoni, 2017-02-15 22:49:18]

+brettw for:
chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
(discussed in offline thread - this will not impact
startup performance)

[brettw, 2017-02-20 17:36:07]

whitelist.cc LGTM as per eng-review thread started Feb 13.

[elichtenberg, 2017-02-21 18:26:09]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 18:26:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:47:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:47:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[elichtenberg, 2017-02-21 21:52:42]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 21:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:58:14]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[elichtenberg, 2017-02-22 01:10:40]

The CQ bit was checked by elichtenberg@google.com

[elichtenberg, 2017-02-22 01:10:40]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2680383002/#ps40001
(title: "Fixing copyright year for new files")

[commit-bot: I haz the power, 2017-02-22 01:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:14:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[dmazzoni, 2017-02-22 07:49:11]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:49:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 07:59:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487749751961050,
"parent_rev": "9b984e4d57f5fae0eb73665bf01df694e43af363", "commit_rev":
"0746c1bd31524520714d53ab8e9f593730efa78a"}

[commit-bot: I haz the power, 2017-02-22 08:00:02]

Description was changed from

==========
Created skeleton for switch access component extension.

If you run Chrome with the --enable-experimental-accessibility-features flag,
then toggling the Switch access checkbox in the accessibility settings loads
or unloads this component extension. This can be verified by inspecting the
extension at chrome://inspect and seeing that switch_access.js logged to the
background console.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Created skeleton for switch access component extension.

If you run Chrome with the --enable-experimental-accessibility-features flag,
then toggling the Switch access checkbox in the accessibility settings loads
or unloads this component extension. This can be verified by inspecting the
extension at chrome://inspect and seeing that switch_access.js logged to the
background console.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2680383002
Cr-Commit-Position: refs/heads/master@{#451915}
Committed:
https://chromium.googlesource.com/chromium/src/+/0746c1bd31524520714d53ab8e9f...
==========

[commit-bot: I haz the power, 2017-02-22 08:00:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0746c1bd31524520714d53ab8e9f...