Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2680373004: Minor Long task idl change: switch from sequence to FrozenArray (Closed)

Created:
3 years, 10 months ago by panicker
Modified:
3 years, 10 months ago
Reviewers:
skobes, tdresser
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor Long task idl change: switch from sequence to FrozenArray https://heycam.github.io/webidl/#idl-attributes advises against use of sequence BUG=681690 Review-Url: https://codereview.chromium.org/2680373004 Cr-Commit-Position: refs/heads/master@{#449768} Committed: https://chromium.googlesource.com/chromium/src/+/f30aaa7e5f0c05b24bf8b6a48ea5906db0ada1dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
panicker
PTAL
3 years, 10 months ago (2017-02-09 20:21:59 UTC) #2
tdresser
LGTM.
3 years, 10 months ago (2017-02-09 20:27:20 UTC) #3
skobes
rs lgtm
3 years, 10 months ago (2017-02-10 17:08:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680373004/1
3 years, 10 months ago (2017-02-10 20:50:48 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 22:38:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f30aaa7e5f0c05b24bf8b6a48ea5...

Powered by Google App Engine
This is Rietveld 408576698