Fixes Object::SetAccessor to return false if the prop is unconfigurable.

Fixes Object::SetAccessor to return false if the prop is unconfigurable.

http://www.ecma-international.org/ecma-262/7.0/#sec-validateandapplypropertydescriptor
says that [[DefineProperty]] should return false if the property is
already defined and it's unconfigurable (exactly speaking, the condition
in the spec is more complicated, but roughly speaking, it's when the
property is unconfigurable).

BUG=chromium:670651
Review-Url: https://codereview.chromium.org/2680353004
Cr-Commit-Position: refs/heads/master@{#43080}
Committed: https://chromium.googlesource.com/v8/v8/+/d014b47fe595b1e119b6c177df0b3234bbc0cf24

[Yuki, 2017-02-09 15:06:29]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 15:06:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-02-09 15:06:44]

yukishiino@chromium.org changed reviewers:
+ jochen@chromium.org

[Yuki, 2017-02-09 15:06:45]

Could you review this CL?

[jochen (gone - plz use gerrit), 2017-02-09 15:23:45]

lgtm

[commit-bot: I haz the power, 2017-02-09 15:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 15:38:46]

Dry run: This issue passed the CQ dry run.

[Yuki, 2017-02-10 05:54:16]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2017-02-10 05:54:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 05:56:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486706056750550, "parent_rev":
"99f1815e24841dbb66fc1676462a5e69b40415c4", "commit_rev":
"d014b47fe595b1e119b6c177df0b3234bbc0cf24"}

[commit-bot: I haz the power, 2017-02-10 05:56:06]

Description was changed from

==========
Fixes Object::SetAccessor to return false if the prop is unconfigurable.

http://www.ecma-international.org/ecma-262/7.0/#sec-validateandapplypropertyd...
says that [[DefineProperty]] should return false if the property is
already defined and it's unconfigurable (exactly speaking, the condition
in the spec is more complicated, but roughly speaking, it's when the
property is unconfigurable).

BUG=chromium:670651
==========

to

==========
Fixes Object::SetAccessor to return false if the prop is unconfigurable.

http://www.ecma-international.org/ecma-262/7.0/#sec-validateandapplypropertyd...
says that [[DefineProperty]] should return false if the property is
already defined and it's unconfigurable (exactly speaking, the condition
in the spec is more complicated, but roughly speaking, it's when the
property is unconfigurable).

BUG=chromium:670651

Review-Url: https://codereview.chromium.org/2680353004
Cr-Commit-Position: refs/heads/master@{#43080}
Committed:
https://chromium.googlesource.com/v8/v8/+/d014b47fe595b1e119b6c177df0b3234bbc...
==========

[commit-bot: I haz the power, 2017-02-10 05:56:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d014b47fe595b1e119b6c177df0b3234bbc...