Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2680353002: Make FakeBookmarkDatabase RefCountedThreadSafe (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make FakeBookmarkDatabase RefCountedThreadSafe FakeBookmarkDatabase had non-thread-safe ref count and is accessed from multiple different threads. So RefCountedThreadSafe should be better fit here. Review-Url: https://codereview.chromium.org/2680353002 Cr-Commit-Position: refs/heads/master@{#449116} Committed: https://chromium.googlesource.com/chromium/src/+/cee359ad61a0b36cc22e4214751ae560713dcd6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/history/core/test/history_client_fake_bookmarks.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-08 16:17:43 UTC) #5
sky
LGTM
3 years, 10 months ago (2017-02-08 17:14:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680353002/1
3 years, 10 months ago (2017-02-08 22:34:18 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 22:47:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cee359ad61a0b36cc22e4214751a...

Powered by Google App Engine
This is Rietveld 408576698