Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2680343002: Add haptic feedback for selection change and action trigger. (Closed)

Created:
3 years, 10 months ago by pink (ping after 24hrs)
Modified:
3 years, 10 months ago
Reviewers:
jif
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add haptic feedback for selection change and action trigger. For iOS10+, trigger haptic feedback during gesture tracking when the selection changes, as well as a different haptic when the user picks an action, either by tapping the item or ending the drag. BUG=690017 TEST=A small bump should be felt on iPhone7 devices when the user changes the selection. A larger bump should be felt when selecting an action. This requires manual testing. Review-Url: https://codereview.chromium.org/2680343002 Cr-Commit-Position: refs/heads/master@{#449334} Committed: https://chromium.googlesource.com/chromium/src/+/e99939bdc44859ee5d918fe424f7d2110cda68e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm View 4 chunks +29 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pink (ping after 24hrs)
3 years, 10 months ago (2017-02-08 15:34:53 UTC) #2
jif
I tried storing the UISelectionFeedbackGenerator and calling |prepare| after |triggerHapticFeedbackForSelectionChange| was called, but I did ...
3 years, 10 months ago (2017-02-08 21:14:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680343002/1
3 years, 10 months ago (2017-02-09 17:16:51 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 17:23:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e99939bdc44859ee5d918fe424f7...

Powered by Google App Engine
This is Rietveld 408576698