Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issue 2680323003: Add UMA histogram for AIA fetching error codes (Closed)

Created:
3 years, 10 months ago by estark
Modified:
3 years, 10 months ago
Reviewers:
eroman, Steven Holte
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA histogram for AIA fetching error codes This CL records the net error code of AIA fetches attempted by CertVerifyProcAndroid. On canary AIA fetching is a bit less effective than I expected (kicking in successfully for ~30% of ERR_CERT_AUTHORITY_INVALID errors instead of expected ~50%), and I'm trying to narrow down if that is due to e.g. random network failures, or something else like insufficient path-building. BUG=688272 Review-Url: https://codereview.chromium.org/2680323003 Cr-Commit-Position: refs/heads/master@{#449769} Committed: https://chromium.googlesource.com/chromium/src/+/96b1db92fdad353c2702419886d5732574eaab33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/cert/cert_verify_proc_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
estark
eroman can you please review the net/ change? holte can you please review histograms.xml? Thanks!
3 years, 10 months ago (2017-02-08 19:58:10 UTC) #4
Steven Holte
histograms lgtm
3 years, 10 months ago (2017-02-08 22:21:13 UTC) #5
eroman
lgtm
3 years, 10 months ago (2017-02-10 20:39:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680323003/1
3 years, 10 months ago (2017-02-10 21:31:02 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 22:39:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96b1db92fdad353c2702419886d5...

Powered by Google App Engine
This is Rietveld 408576698