Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2680313009: Check if a PBO is or isn't bound in {compressed}Tex{Sub}Image{2|3}D in WebGL2. (Closed)

Created:
3 years, 10 months ago by Zhenyao Mo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, haraken, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if a PBO is or isn't bound in {compressed}Tex{Sub}Image{2|3}D in WebGL2. BUG=690335 TEST=https://github.com/KhronosGroup/WebGL/pull/2293 R=kainino@chromium.org,kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2680313009 Cr-Commit-Position: refs/heads/master@{#449541} Committed: https://chromium.googlesource.com/chromium/src/+/6471880c327892a402eb91e2b260802c9f38b03f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 44 chunks +292 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Zhenyao Mo
PTAL
3 years, 10 months ago (2017-02-10 00:42:26 UTC) #3
Kai Ninomiya
Looks great, LGTM. Thanks for picking this up for me. I didn't realize the check ...
3 years, 10 months ago (2017-02-10 00:53:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680313009/1
3 years, 10 months ago (2017-02-10 03:06:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 03:23:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6471880c327892a402eb91e2b260...

Powered by Google App Engine
This is Rietveld 408576698