Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: runtime/observatory/tests/service/get_object_rpc_test.dart

Issue 2680303002: Kernel debugging; service tests (Closed)
Patch Set: Changes based on feedback. Also fixed regress_28443_test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/get_object_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_object_rpc_test.dart b/runtime/observatory/tests/service/get_object_rpc_test.dart
index e933d4916e62299b2063c61f75cb5fb6cf70b21d..d3b056afc40eeeb35bb474219a13d545070bbade 100644
--- a/runtime/observatory/tests/service/get_object_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_object_rpc_test.dart
@@ -658,8 +658,11 @@ var tests = [
expect(result['uri'], startsWith('file:'));
expect(result['uri'], endsWith('get_object_rpc_test.dart'));
expect(result['debuggable'], equals(true));
- expect(result['dependencies'].length, isPositive);
- expect(result['dependencies'][0]['target']['type'], equals('@Library'));
+ if (!isKernel(isolate)) {
+ // There are no imports and exports in kernel.
+ expect(result['dependencies'].length, isPositive);
+ expect(result['dependencies'][0]['target']['type'], equals('@Library'));
+ }
expect(result['scripts'].length, isPositive);
expect(result['scripts'][0]['type'], equals('@Script'));
expect(result['variables'].length, isPositive);
@@ -704,7 +707,11 @@ var tests = [
expect(result['id'], startsWith('libraries/'));
expect(result['uri'], startsWith('file:'));
expect(result['uri'], endsWith('get_object_rpc_test.dart'));
- expect(result['_kind'], equals('script'));
+ if (isKernel(isolate)) {
+ expect(result['_kind'], equals('kernel'));
+ } else {
+ expect(result['_kind'], equals('script'));
+ }
expect(result['library']['type'], equals('@Library'));
expect(result['source'], startsWith('// Copyright (c)'));
expect(result['tokenPosTable'].length, isPositive);

Powered by Google App Engine
This is Rietveld 408576698