Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: runtime/observatory/tests/service/get_source_report_test.dart

Issue 2680303002: Kernel debugging; service tests (Closed)
Patch Set: Changes based on feedback. Also fixed regress_28443_test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/get_source_report_test.dart
diff --git a/runtime/observatory/tests/service/get_source_report_test.dart b/runtime/observatory/tests/service/get_source_report_test.dart
index 81f21a5bbc657380db03ed627de51bada92c5b87..4fba4a9801687d89363c536ab56c1ee156a5ba20 100644
--- a/runtime/observatory/tests/service/get_source_report_test.dart
+++ b/runtime/observatory/tests/service/get_source_report_test.dart
@@ -61,13 +61,24 @@ hasStoppedAtBreakpoint,
expect(func.name, equals('myFunction'));
await func.load();
- var expectedRange = {
- 'scriptIndex': 0,
- 'startPos': 39,
- 'endPos': 88,
- 'compiled': true,
- 'coverage': {'hits': [54, 72, 82], 'misses': [60]}
- };
+ var expectedRange;
+ if (isKernel(isolate)) {
+ expectedRange = {
+ 'scriptIndex': 0,
+ 'startPos': 501,
+ 'endPos': 633,
+ 'compiled': true,
+ 'coverage': {'hits': [539, 590, 619], 'misses': [552]}
+ };
+ } else {
+ expectedRange = {
+ 'scriptIndex': 0,
+ 'startPos': 39,
+ 'endPos': 88,
+ 'compiled': true,
+ 'coverage': {'hits': [54, 72, 82], 'misses': [60]}
+ };
+ }
// Full script
var params = { 'reports' : ['Coverage'],
@@ -87,7 +98,11 @@ hasStoppedAtBreakpoint,
'forceCompile' : true };
coverage = await isolate.invokeRpcNoUpgrade('getSourceReport', params);
expect(coverage['type'], equals('SourceReport'));
- expect(coverage['ranges'].length, 6);
+ if (isKernel(isolate)) {
+ expect(coverage['ranges'].length, 7); // kernel async transform adds one.
+ } else {
+ expect(coverage['ranges'].length, 6);
+ }
expect(allRangesCompiled(coverage), isTrue);
// One function

Powered by Google App Engine
This is Rietveld 408576698