Kernel debugging; service tests

runtime/observatory/tests/service/set_library_debuggable_test.dart

Index: runtime/observatory/tests/service/set_library_debuggable_test.dart
diff --git a/runtime/observatory/tests/service/set_library_debuggable_test.dart b/runtime/observatory/tests/service/set_library_debuggable_test.dart
index d76569c5d1849d64271a25e672ab40e3af1e9ed1..970478bae779311b23eb4d4834075ba35944f0f6 100644
--- a/runtime/observatory/tests/service/set_library_debuggable_test.dart
+++ b/runtime/observatory/tests/service/set_library_debuggable_test.dart
@@ -30,12 +30,12 @@ var tests = [
     await dartCore.load();
     expect(dartCore.debuggable, equals(true));
   },
-  stoppedInFunction('testMain', contains:true),
+  stoppedInFunction('testMain', contains: true, includeOwner: true),

[Cutch, 2017/02/08 16:48:20]

why is includeOwner needed here?

[jensj, 2017/02/13 14:04:16]

From source the name of the async function is something like
"testMain_async_body", via kernel it's just "async_op", so without includeOwner
I get the following error:
"Expected to be in function testMain but actually in function async_op".

[Cutch, 2017/03/07 01:58:37]

The function names reported via kernel and the VM today need to be the same.

[jensj, 2017/03/07 08:43:40]

I actually think they are today. It was done a week or so ago. I'll remove the
includeOwner stuff.
It's not currently easy to test though, as the switch to fasta removed all
debugging support.

   stoppedAtLine(LINE_A),
   stepInto,
   stoppedInFunction('print'),
   stepOut,
-  stoppedInFunction('testMain', contains:true),
+  stoppedInFunction('testMain', contains: true, includeOwner: true),

[Cutch, 2017/03/07 01:58:37]

dito here

   stoppedAtLine(LINE_B),
   (Isolate isolate) async {
     // Mark 'dart:core' as not debuggable.
@@ -55,10 +55,10 @@ var tests = [
     await dartCore.reload();
     expect(dartCore.debuggable, equals(false));
   },
-  stoppedInFunction('testMain', contains:true),
+  stoppedInFunction('testMain', contains: true, includeOwner: true),
   stoppedAtLine(LINE_B),
   stepInto,
-  stoppedInFunction('testMain', contains:true),
+  stoppedInFunction('testMain', contains: true, includeOwner: true),
   stoppedAtLine(LINE_C),
 ];