Kernel debugging; service tests

runtime/observatory/tests/service/set_library_debuggable_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // VMOptions=--error_on_bad_type --error_on_bad_override
 
 library set_library_debuggable_test;
 
 import 'dart:developer';
 import 'package:observatory/service_io.dart';
 import 'package:unittest/unittest.dart';
@@ skipping 12 matching lines @@
 }
 
 var tests = [
   (Isolate isolate) async {
     await isolate.reload();
     Library dartCore = isolate.libraries.firstWhere(
       (Library library) => library.uri == 'dart:core');
     await dartCore.load();
     expect(dartCore.debuggable, equals(true));
   },
-  stoppedInFunction('testMain', contains:true),
+  stoppedInFunction('testMain', contains: true, includeOwner: true),

[Cutch, 2017/02/08 16:48:20]

why is includeOwner needed here?

[jensj, 2017/02/13 14:04:16]

From source the name of the async function is something like
"testMain_async_body", via kernel it's just "async_op", so without includeOwner
I get the following error:
"Expected to be in function testMain but actually in function async_op".

[Cutch, 2017/03/07 01:58:37]

The function names reported via kernel and the VM today need to be the same.

[jensj, 2017/03/07 08:43:40]

I actually think they are today. It was done a week or so ago. I'll remove the
includeOwner stuff.
It's not currently easy to test though, as the switch to fasta removed all
debugging support.

   stoppedAtLine(LINE_A),
   stepInto,
   stoppedInFunction('print'),
   stepOut,
-  stoppedInFunction('testMain', contains:true),
+  stoppedInFunction('testMain', contains: true, includeOwner: true),

[Cutch, 2017/03/07 01:58:37]

dito here

   stoppedAtLine(LINE_B),
   (Isolate isolate) async {
     // Mark 'dart:core' as not debuggable.
     await isolate.reload();
     Library dartCore = isolate.libraries.firstWhere(
       (Library library) => library.uri == 'dart:core');
     await dartCore.load();
     expect(dartCore.debuggable, equals(true));
     var setDebugParams = {
       'libraryId': dartCore.id,
       'isDebuggable': false,
     };
     Map<String, dynamic> result =
         await isolate.invokeRpcNoUpgrade('setLibraryDebuggable',
                                          setDebugParams);
     expect(result['type'], equals('Success'));
     await dartCore.reload();
     expect(dartCore.debuggable, equals(false));
   },
-  stoppedInFunction('testMain', contains:true),
+  stoppedInFunction('testMain', contains: true, includeOwner: true),
   stoppedAtLine(LINE_B),
   stepInto,
-  stoppedInFunction('testMain', contains:true),
+  stoppedInFunction('testMain', contains: true, includeOwner: true),
   stoppedAtLine(LINE_C),
 ];
 
 main(args) async => runIsolateTests(args, tests, testeeConcurrent: testMain);