Kernel debugging; service tests

runtime/observatory/tests/service/get_object_rpc_test.dart

Index: runtime/observatory/tests/service/get_object_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_object_rpc_test.dart b/runtime/observatory/tests/service/get_object_rpc_test.dart
index e933d4916e62299b2063c61f75cb5fb6cf70b21d..d3b056afc40eeeb35bb474219a13d545070bbade 100644
--- a/runtime/observatory/tests/service/get_object_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_object_rpc_test.dart
@@ -658,8 +658,11 @@ var tests = [
     expect(result['uri'], startsWith('file:'));
     expect(result['uri'], endsWith('get_object_rpc_test.dart'));
     expect(result['debuggable'], equals(true));
-    expect(result['dependencies'].length, isPositive);
-    expect(result['dependencies'][0]['target']['type'], equals('@Library'));
+    if (!isKernel(isolate)) {
+      // There are no imports and exports in kernel.
+      expect(result['dependencies'].length, isPositive);

[Kevin Millikin (Google), 2017/02/08 15:37:51]

Do we plan to construct them, or do we think they are not needed?

[Cutch, 2017/02/08 16:48:20]

Please do not add public fields to the service protocol.

[Cutch, 2017/02/08 22:02:37]

Ignore. I misread this code, this isn't a new field.

[jensj, 2017/02/13 14:04:15]

I haven't talked to anyone about it. It shown in the observatory interface, but
other than that I'm not sure what it's actually used for.

+      expect(result['dependencies'][0]['target']['type'], equals('@Library'));
+    }
     expect(result['scripts'].length, isPositive);
     expect(result['scripts'][0]['type'], equals('@Script'));
     expect(result['variables'].length, isPositive);
@@ -704,7 +707,11 @@ var tests = [
     expect(result['id'], startsWith('libraries/'));
     expect(result['uri'], startsWith('file:'));
     expect(result['uri'], endsWith('get_object_rpc_test.dart'));
-    expect(result['_kind'], equals('script'));
+    if (isKernel(isolate)) {

[Cutch, 2017/02/08 16:48:20]

please find a way to express this without adding all of these 'if kernel else'
branches to tests.

[Kevin Millikin (Google), 2017/02/08 19:38:21]

Do you have a suggestion?

[jensj, 2017/02/13 14:04:15]

The only other way I see is to do what I've done with e.g.
add_breakpoint_rpc_kernel_test.dart vs add_breakpoint_rpc_test.dart - i.e.
create a copy, make it kernel specific, skip the kernel one in the vm status
file, and skip the original one in the kernel status file. I though this was
better in this case.

If you prefer I can split out the 3 files that use this though
(get_object_rpc_test.dart, get_source_report_test.dart and
set_name_rpc_test.dart).

[Cutch, 2017/03/07 01:58:37]

Why not create a helper functions which include the if (isKernel(...)) and then
just call those in the tests?

+      expect(result['_kind'], equals('kernel'));
+    } else {
+      expect(result['_kind'], equals('script'));
+    }
     expect(result['library']['type'], equals('@Library'));
     expect(result['source'], startsWith('// Copyright (c)'));
     expect(result['tokenPosTable'].length, isPositive);