Kernel debugging; service tests

runtime/observatory/tests/service/get_object_rpc_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // VMOptions=--error_on_bad_type --error_on_bad_override
 
 library get_object_rpc_test;
 
 import 'dart:typed_data';
 import 'dart:convert' show BASE64;
 import 'package:observatory/service_io.dart';
@@ skipping 640 matching lines @@
     var params = {
       'objectId': isolate.rootLibrary.id,
     };
     var result = await isolate.invokeRpcNoUpgrade('getObject', params);
     expect(result['type'], equals('Library'));
     expect(result['id'], startsWith('libraries/'));
     expect(result['name'], equals('get_object_rpc_test'));
     expect(result['uri'], startsWith('file:'));
     expect(result['uri'], endsWith('get_object_rpc_test.dart'));
     expect(result['debuggable'], equals(true));
-    expect(result['dependencies'].length, isPositive);
-    expect(result['dependencies'][0]['target']['type'], equals('@Library'));
+    if (!isKernel(isolate)) {
+      // There are no imports and exports in kernel.
+      expect(result['dependencies'].length, isPositive);

[Kevin Millikin (Google), 2017/02/08 15:37:51]

Do we plan to construct them, or do we think they are not needed?

[Cutch, 2017/02/08 16:48:20]

Please do not add public fields to the service protocol.

[Cutch, 2017/02/08 22:02:37]

Ignore. I misread this code, this isn't a new field.

[jensj, 2017/02/13 14:04:15]

I haven't talked to anyone about it. It shown in the observatory interface, but
other than that I'm not sure what it's actually used for.

+      expect(result['dependencies'][0]['target']['type'], equals('@Library'));
+    }
     expect(result['scripts'].length, isPositive);
     expect(result['scripts'][0]['type'], equals('@Script'));
     expect(result['variables'].length, isPositive);
     expect(result['variables'][0]['type'], equals('@Field'));
     expect(result['functions'].length, isPositive);
     expect(result['functions'][0]['type'], equals('@Function'));
     expect(result['classes'].length, isPositive);
     expect(result['classes'][0]['type'], equals('@Class'));
   },
 
@@ skipping 24 matching lines @@
     var libResult = await isolate.invokeRpcNoUpgrade('getObject', params);
     // Get the first script.
     params = {
       'objectId': libResult['scripts'][0]['id'],
     };
     var result = await isolate.invokeRpcNoUpgrade('getObject', params);
     expect(result['type'], equals('Script'));
     expect(result['id'], startsWith('libraries/'));
     expect(result['uri'], startsWith('file:'));
     expect(result['uri'], endsWith('get_object_rpc_test.dart'));
-    expect(result['_kind'], equals('script'));
+    if (isKernel(isolate)) {

[Cutch, 2017/02/08 16:48:20]

please find a way to express this without adding all of these 'if kernel else'
branches to tests.

[Kevin Millikin (Google), 2017/02/08 19:38:21]

Do you have a suggestion?

[jensj, 2017/02/13 14:04:15]

The only other way I see is to do what I've done with e.g.
add_breakpoint_rpc_kernel_test.dart vs add_breakpoint_rpc_test.dart - i.e.
create a copy, make it kernel specific, skip the kernel one in the vm status
file, and skip the original one in the kernel status file. I though this was
better in this case.

If you prefer I can split out the 3 files that use this though
(get_object_rpc_test.dart, get_source_report_test.dart and
set_name_rpc_test.dart).

[Cutch, 2017/03/07 01:58:37]

Why not create a helper functions which include the if (isKernel(...)) and then
just call those in the tests?

+      expect(result['_kind'], equals('kernel'));
+    } else {
+      expect(result['_kind'], equals('script'));
+    }
     expect(result['library']['type'], equals('@Library'));
     expect(result['source'], startsWith('// Copyright (c)'));
     expect(result['tokenPosTable'].length, isPositive);
     expect(result['tokenPosTable'][0], new isInstanceOf<List>());
     expect(result['tokenPosTable'][0].length, isPositive);
     expect(result['tokenPosTable'][0][0], new isInstanceOf<int>());
   },
 
   // invalid script.
   (Isolate isolate) async {
@@ skipping 229 matching lines @@
       caughtException = true;
       expect(e.code, equals(ServerRpcException.kInvalidParams));
       expect(e.message,
              "getObject: invalid 'objectId' parameter: code/0");
     }
     expect(caughtException, isTrue);
   },
 ];
 
 main(args) async => runIsolateTests(args, tests, testeeBefore:warmup);