Follow-ups/Tweaks for Embedded Flash Fullscreen.

Follow-ups/Tweaks for Embedded Flash Fullscreen.

1. Added mouse lock support for the embedded flash fullscreen widget using the existing Flash-privileged mechanism.
2. Removed the redundant "Press Esc to Exit Fullscreen" balloon pop-up, in favor of Flash's built-in message.
3. Fixed bug where the status bubble/tooltip (at lower-left) was not being hidden while in fullscreen mode.

Testing: Ran unit tests.  Manually confirmed all of the above work as intended both with *and* without the --embed-flash-fullscreen command-line flag.  Tested on Linux/Win Aura, Mac, and Win non-Aura.

BUG=290403, 256870
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228334

[miu, 2013-10-10 22:20:59]

yzshen/rsesek: Please review.
sky: OWNERS stamp.

Pretty straightforward, simple fixes for the UI issues noted in previous
discussions/crbugs.  We've decided to let Flash retain fullscreen and mouse-lock
permissions control.  In the longer-term, we'll look at delegating this
functionality to the Chrome browser UI (i.e., HTML5-style fullscreen).

After this change, the one issue remaining is Mac Fullscreen behavior (on
multi-monitor desktops).  I'll follow-up again with rsesek@ on that.

Thanks,
Yuri

[scheib, 2013-10-11 00:27:17]

lgtm

[sky, 2013-10-11 01:56:28]

https://codereview.chromium.org/26803002/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/browser_view.cc (left):

https://codereview.chromium.org/26803002/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/browser_view.cc:2323:
!ShouldUseImmersiveFullscreenForUrl(url)) {
Why are you removing the !ShouldUseImm...?

[miu, 2013-10-11 03:30:29]

https://codereview.chromium.org/26803002/diff/1/chrome/browser/ui/views/frame...
File chrome/browser/ui/views/frame/browser_view.cc (left):

https://codereview.chromium.org/26803002/diff/1/chrome/browser/ui/views/frame...
chrome/browser/ui/views/frame/browser_view.cc:2323:
!ShouldUseImmersiveFullscreenForUrl(url)) {
On 2013/10/11 01:56:28, sky wrote:
> Why are you removing the !ShouldUseImm...?

It's checked in the call to UpdateFullscreenExitBubbleContent() and so it's now
redundant to have here.

[sky, 2013-10-11 15:23:27]

LGTM

[Robert Sesek, 2013-10-11 17:48:27]

LGTM

[yzshen1, 2013-10-11 18:01:49]

lgtm

[commit-bot: I haz the power, 2013-10-11 19:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/26803002/1

[commit-bot: I haz the power, 2013-10-12 05:46:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/26803002/1

[commit-bot: I haz the power, 2013-10-12 07:42:34]

Change committed as 228334