Follow-ups/Tweaks for Embedded Flash Fullscreen.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 2300 matching lines @@
     frame_->SetFullscreen(fullscreen);
   }
 
   // Enable immersive before the browser refreshes its list of enabled commands.
   if (ShouldUseImmersiveFullscreenForUrl(url))
     immersive_mode_controller_->SetEnabled(fullscreen);
 
   browser_->WindowFullscreenStateChanged();
 
   if (fullscreen) {
-    if (!chrome::IsRunningInAppMode() &&
-        type != FOR_METRO &&
-        !ShouldUseImmersiveFullscreenForUrl(url)) {

[sky, 2013/10/11 01:56:28]

Why are you removing the !ShouldUseImm...?

[miu, 2013/10/11 03:30:30]

It's checked in the call to UpdateFullscreenExitBubbleContent() and so it's now
redundant to have here.

-      fullscreen_bubble_.reset(new FullscreenExitBubbleViews(
-          this, url, bubble_type));
-    }
+    if (!chrome::IsRunningInAppMode() && type != FOR_METRO)
+      UpdateFullscreenExitBubbleContent(url, bubble_type);
   } else {
 #if defined(OS_WIN) && !defined(USE_AURA)
     if (omnibox_win) {
       // Show the edit again since we're no longer in fullscreen mode.
       omnibox_win->set_force_hidden(false);
       ShowWindow(omnibox_win->m_hWnd, SW_SHOW);
     }
 #endif
   }
 
@@ skipping 341 matching lines @@
     // The +1 in the next line creates a 1-px gap between icon and arrow tip.
     gfx::Point icon_bottom(0, location_icon_view->GetImageBounds().bottom() -
         LocationBarView::kIconInternalPadding + 1);
     ConvertPointToTarget(location_icon_view, this, &icon_bottom);
     gfx::Point infobar_top(0, infobar_container_->GetVerticalOverlap(NULL));
     ConvertPointToTarget(infobar_container_, this, &infobar_top);
     top_arrow_height = infobar_top.y() - icon_bottom.y();
   }
   return top_arrow_height;
 }