The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
estade@chromium.org changed reviewers: + tdanderson@chromium.org
LGTM with one optional comment https://codereview.chromium.org/2680223002/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/session/logout_button_tray.cc (right): https://codereview.chromium.org/2680223002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/session/logout_button_tray.cc:118: const int button_size = kTrayItemSize; Or consider just having kTrayItemSize inlined on lines 122 and 128 and removing |button_size|.
https://codereview.chromium.org/2680223002/diff/1/ash/common/system/chromeos/... File ash/common/system/chromeos/session/logout_button_tray.cc (right): https://codereview.chromium.org/2680223002/diff/1/ash/common/system/chromeos/... ash/common/system/chromeos/session/logout_button_tray.cc:118: const int button_size = kTrayItemSize; On 2017/02/08 01:08:54, tdanderson wrote: > Or consider just having kTrayItemSize inlined on lines 122 and 128 and removing > |button_size|. Done.
The CQ bit was checked by estade@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tdanderson@chromium.org Link to the patchset: https://codereview.chromium.org/2680223002/#ps20001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486519005291330, "parent_rev": "ea0db23fb2e131fc223628e6dc40d84c66fee816", "commit_rev": "3cc64b8397bc68525879441dd41fa7a3082aeb83"}
Description was changed from ========== Remove pre-MD cros tray logout button assets and code. BUG=686296 ========== to ========== Remove pre-MD cros tray logout button assets and code. BUG=686296 Review-Url: https://codereview.chromium.org/2680223002 Cr-Commit-Position: refs/heads/master@{#448865} Committed: https://chromium.googlesource.com/chromium/src/+/3cc64b8397bc68525879441dd41f... ==========
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3cc64b8397bc68525879441dd41f...