Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 2680203004: Do RTL tabstrip transforms before animating tabs. (Closed)

Created:
3 years, 10 months ago by Avi (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do RTL tabstrip transforms before animating tabs. BUG=672873 TEST=as in bug Review-Url: https://codereview.chromium.org/2680203004 Cr-Commit-Position: refs/heads/master@{#449199} Committed: https://chromium.googlesource.com/chromium/src/+/d1065b766d40d754475f9270eea5ed3ce295e81b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 10 months ago (2017-02-08 22:09:40 UTC) #6
erikchen
lgtm
3 years, 10 months ago (2017-02-08 22:48:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680203004/1
3 years, 10 months ago (2017-02-09 02:33:01 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 04:34:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1065b766d40d754475f9270eea5...

Powered by Google App Engine
This is Rietveld 408576698