Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 26802003: Make units-000.htm from ietestcenter pass. (Closed)

Created:
7 years, 2 months ago by rune
Modified:
7 years, 2 months ago
Reviewers:
eae, eseidel
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make units-000.htm from ietestcenter pass. In order to do this I had to: - Change the incorrect unit vm to vmin which was already done on the IE test center site. - Modify the test to use a font-size of 20px instead of 16px for the Ahem font to work around a font rendering issue in Blink. - Better support for viewport relative lengths for border. Viewport relative lengths for the border-width properties translated from the number value of the viewport relative units to a pixel length without taking the viewport size into account. The code now converts to a px length through conversion of a Length object using the RenderView. BUG=webkit.org/b/85308 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159363

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/ietestcenter/css3/valuesandunits/units-000.htm View 5 chunks +33 lines, -27 lines 0 comments Download
M LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.h View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
rune
7 years, 2 months ago (2013-10-10 11:46:07 UTC) #1
rune
https://codereview.chromium.org/26802003/diff/1/Source/core/css/resolver/StyleBuilderCustom.h File Source/core/css/resolver/StyleBuilderCustom.h (right): https://codereview.chromium.org/26802003/diff/1/Source/core/css/resolver/StyleBuilderCustom.h#newcode72 Source/core/css/resolver/StyleBuilderCustom.h:72: return intValueForLength(primitiveValue->viewportPercentageLength(), 0, state.document().renderView()); To reviewer: I should have ...
7 years, 2 months ago (2013-10-10 11:59:45 UTC) #2
eae
LGTM https://codereview.chromium.org/26802003/diff/1/Source/core/css/resolver/StyleBuilderCustom.h File Source/core/css/resolver/StyleBuilderCustom.h (right): https://codereview.chromium.org/26802003/diff/1/Source/core/css/resolver/StyleBuilderCustom.h#newcode72 Source/core/css/resolver/StyleBuilderCustom.h:72: return intValueForLength(primitiveValue->viewportPercentageLength(), 0, state.document().renderView()); Ints is right for ...
7 years, 2 months ago (2013-10-10 15:25:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/26802003/1
7 years, 2 months ago (2013-10-10 16:23:28 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=7573
7 years, 2 months ago (2013-10-10 17:38:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/26802003/1
7 years, 2 months ago (2013-10-10 17:59:52 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 19:06:25 UTC) #7
Message was sent while issue was closed.
Change committed as 159363

Powered by Google App Engine
This is Rietveld 408576698