Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.h

Issue 26802003: Make units-000.htm from ietestcenter pass. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/StyleBuilderCustom.h
diff --git a/Source/core/css/resolver/StyleBuilderCustom.h b/Source/core/css/resolver/StyleBuilderCustom.h
index bb1528e6f7ce0b1e49c19204b25fabd696f06cc0..e2156f0d62c00ceffd976ad33fe7fec567439226 100644
--- a/Source/core/css/resolver/StyleBuilderCustom.h
+++ b/Source/core/css/resolver/StyleBuilderCustom.h
@@ -69,7 +69,7 @@ T StyleBuilderConverter::convertLineWidth(StyleResolverState& state, CSSValue* v
if (valueID == CSSValueThick)
return 5;
if (primitiveValue->isViewportPercentageLength())
- return primitiveValue->viewportPercentageLength().value();
+ return intValueForLength(primitiveValue->viewportPercentageLength(), 0, state.document().renderView());
rune 2013/10/10 11:59:45 To reviewer: I should have converted to float ins
eae 2013/10/10 15:25:01 Ints is right for borders. Good catch.
if (valueID == CSSValueInvalid) {
float zoom = state.style()->effectiveZoom();
// Any original result that was >= 1 should not be allowed to fall below 1.
« no previous file with comments | « LayoutTests/ietestcenter/css3/valuesandunits/units-000-expected.htm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698