[ash-md] Remove non-md code from the Shelf background animations.

[ash-md] Remove non-md code from the Shelf background animations.

This change removes the asset based background used by pre-material
design shelf animations.

BUG=687810
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2680113002
Cr-Commit-Position: refs/heads/master@{#449111}
Committed: https://chromium.googlesource.com/chromium/src/+/273c082d54d0403ca0b7fb65729cee7ff25473f0

[bruthig, 2017-02-07 21:21:46]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 21:23:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2017-02-07 21:27:01]

Description was changed from

==========
[ash-md] Remove non-md code from the Shelf background animations.

BUG=687810
==========

to

==========
[ash-md] Remove non-md code from the Shelf background animations.

This change removes the asset based background used by pre-material
design shelf animations.

BUG=687810
TEST=ash_unittests
==========

[bruthig, 2017-02-07 21:28:00]

bruthig@chromium.org changed reviewers:
+ jamescook@chromium.org

[bruthig, 2017-02-07 21:28:01]

James, can you PTAL?

https://codereview.chromium.org/2680113002/diff/1/ash/common/wm/background_an...
File ash/common/wm/background_animator.h (right):

https://codereview.chromium.org/2680113002/diff/1/ash/common/wm/background_an...
ash/common/wm/background_animator.h:10: #include
"third_party/skia/include/core/SkColor.h"
Ignore this, this file is being deleted in a follow up CL anyway.

[commit-bot: I haz the power, 2017-02-07 22:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 22:43:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2017-02-07 23:05:03]

I can look in a couple hours. In the mean time it looks like you have some test
failures.

[James Cook, 2017-02-07 23:50:16]

Code seems fine, but the test failures concern me.

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_back...
File ash/common/shelf/shelf_background_animator.cc (right):

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_back...
ash/common/shelf/shelf_background_animator.cc:145: const bool is_material =
MaterialDesignController::IsShelfMaterial();
Should this be removed?

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
File ash/common/shelf/shelf_widget.cc (left):

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
ash/common/shelf/shelf_widget.cc:88: // TODO(bruthig): Remove opaque_background_
(see https://crbug.com/621551).
This TODO doesn't seem done. What's going on with this?

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
ash/common/shelf/shelf_widget.cc:133:
*rb->GetImageSkiaNamed(IDR_ASH_SHELF_BACKGROUND);
Thanks for remembering to remove the asset files too.

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
File ash/common/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
ash/common/shelf/shelf_widget.cc:79:
ShelfWidget::DelegateView::DelegateView(WmShelf* wm_shelf,
wm_shelf is unused? remove it?

https://codereview.chromium.org/2680113002/diff/1/ash/common/wm/dock/docked_w...
File ash/common/wm/dock/docked_window_layout_manager.cc (left):

https://codereview.chromium.org/2680113002/diff/1/ash/common/wm/dock/docked_w...
ash/common/wm/dock/docked_window_layout_manager.cc:33: #include
"ui/gfx/image/image_skia_operations.h"
Can this be removed?

https://codereview.chromium.org/2680113002/diff/1/ash/common/wm/dock/docked_w...
ash/common/wm/dock/docked_window_layout_manager.cc:200: // TODO(bruthig): Remove
opaque_background_ (see https://crbug.com/621551).
ditto. It seems like the bug needs an update and these comments need to be
expanded if these background layers are still needed.

[bruthig, 2017-02-08 18:11:19]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 18:11:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 18:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 18:14:03]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[bruthig, 2017-02-08 19:27:30]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 19:28:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:02:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:02:05]

Dry run: This issue passed the CQ dry run.

[bruthig, 2017-02-08 21:05:29]

Thx James.  Can you take another look?

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_back...
File ash/common/shelf/shelf_background_animator.cc (right):

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_back...
ash/common/shelf/shelf_background_animator.cc:145: const bool is_material =
MaterialDesignController::IsShelfMaterial();
On 2017/02/07 23:50:16, James Cook wrote:
> Should this be removed?

Done.

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
File ash/common/shelf/shelf_widget.cc (left):

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
ash/common/shelf/shelf_widget.cc:88: // TODO(bruthig): Remove opaque_background_
(see https://crbug.com/621551).
On 2017/02/07 23:50:16, James Cook wrote:
> This TODO doesn't seem done. What's going on with this?

Originally I was planning to update issue 621551 as WontFix but I need to double
check on something.  So I've added the TODO back for now.  I will address in a
follow-up.

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
File ash/common/shelf/shelf_widget.cc (right):

https://codereview.chromium.org/2680113002/diff/1/ash/common/shelf/shelf_widg...
ash/common/shelf/shelf_widget.cc:79:
ShelfWidget::DelegateView::DelegateView(WmShelf* wm_shelf,
On 2017/02/07 23:50:16, James Cook wrote:
> wm_shelf is unused? remove it?

Done.

https://codereview.chromium.org/2680113002/diff/1/ash/common/wm/dock/docked_w...
File ash/common/wm/dock/docked_window_layout_manager.cc (left):

https://codereview.chromium.org/2680113002/diff/1/ash/common/wm/dock/docked_w...
ash/common/wm/dock/docked_window_layout_manager.cc:33: #include
"ui/gfx/image/image_skia_operations.h"
On 2017/02/07 23:50:16, James Cook wrote:
> Can this be removed?

Done.

https://codereview.chromium.org/2680113002/diff/1/ash/common/wm/dock/docked_w...
ash/common/wm/dock/docked_window_layout_manager.cc:200: // TODO(bruthig): Remove
opaque_background_ (see https://crbug.com/621551).
On 2017/02/07 23:50:16, James Cook wrote:
> ditto. It seems like the bug needs an update and these comments need to be
> expanded if these background layers are still needed.

Originally I was planning to update issue 621551 as WontFix but I need to double
check on something.  So I've added the TODO back for now.  I will address in a
follow-up.

[James Cook, 2017-02-08 22:21:51]

LGTM!

[bruthig, 2017-02-08 22:28:28]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2017-02-08 22:28:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 22:34:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486592908073730,
"parent_rev": "ce3f7a721ca8dabb1b13ba506d9980d60c5e02ac", "commit_rev":
"273c082d54d0403ca0b7fb65729cee7ff25473f0"}

[commit-bot: I haz the power, 2017-02-08 22:34:40]

Description was changed from

==========
[ash-md] Remove non-md code from the Shelf background animations.

This change removes the asset based background used by pre-material
design shelf animations.

BUG=687810
TEST=ash_unittests
==========

to

==========
[ash-md] Remove non-md code from the Shelf background animations.

This change removes the asset based background used by pre-material
design shelf animations.

BUG=687810
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2680113002
Cr-Commit-Position: refs/heads/master@{#449111}
Committed:
https://chromium.googlesource.com/chromium/src/+/273c082d54d0403ca0b7fb65729c...
==========

[commit-bot: I haz the power, 2017-02-08 22:34:41]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/273c082d54d0403ca0b7fb65729c...