Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2680083005: [Mac] Test for Omnibox Touch Bar (Closed)

Created:
3 years, 10 months ago by spqchan
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Test for Omnibox Touch Bar BUG=680023 Review-Url: https://codereview.chromium.org/2680083005 Cr-Commit-Position: refs/heads/master@{#449224} Committed: https://chromium.googlesource.com/chromium/src/+/b611e84af4f6d181789aab819af189c3e6c71b9f

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
spqchan
PTAL
3 years, 10 months ago (2017-02-08 19:07:11 UTC) #7
Robert Sesek
lgtm https://codereview.chromium.org/2680083005/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm (right): https://codereview.chromium.org/2680083005/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm#newcode202 chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm:202: NSTouchBar* touchBar = [field_ performSelector:@selector(touchBar)]; nit: touch_bar
3 years, 10 months ago (2017-02-08 20:06:44 UTC) #8
spqchan
On 2017/02/08 20:06:44, Robert Sesek wrote: > lgtm > > https://codereview.chromium.org/2680083005/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm > File > chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor_unittest.mm ...
3 years, 10 months ago (2017-02-09 05:54:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680083005/40001
3 years, 10 months ago (2017-02-09 05:55:43 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 06:20:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b611e84af4f6d181789aab819af1...

Powered by Google App Engine
This is Rietveld 408576698