Convert OfflineAudioContext tests to testharness

Convert OfflineAudioContext tests to testharness

Manually convert these tests to testharness and new Audit.

BUG=689076
TEST=

Review-Url: https://codereview.chromium.org/2680033002
Cr-Commit-Position: refs/heads/master@{#450481}
Committed: https://chromium.googlesource.com/chromium/src/+/7832d67481ad51c31126552301df007efb57fa8a

[Raymond Toy, 2017-02-07 17:01:04]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-07 17:01:05]

PTAL

[hongchan, 2017-02-07 18:38:43]

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise.html
(right):

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise.html:63:
context.oncomplete = event => {
For clarity, let's do this:

context.oncomplete = (event) => {
 // stuff
};

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise.html:65:
};;
Two semicolons.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html
(right):

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html:37:
scheduledSuspendTime,
Is this the result from clang-format? This is weird.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html:67:
should(context.state, 'oncomplete event handler:
context.state').beEqualTo('closed');
Needs to be wrapped at 80.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html
(right):

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html:29:
scheduledSuspendTime) {
I find this line break is weird. This should be:

if (context.state === 'suspended'
    && context.currentTime === scheduledSuspendTime)

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html:31:
scheduledSuspendTime,
Ditto.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/onstatechange.html
(right):

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/onstatechange.html:66:
context.onstatechange = (e) => checkStateChange(e, should);
(event)

[Raymond Toy, 2017-02-07 19:11:10]

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise.html
(right):

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise.html:63:
context.oncomplete = event => {
On 2017/02/07 18:38:43, hongchan wrote:
> For clarity, let's do this:
> 
> context.oncomplete = (event) => {
>  // stuff
> };

Done.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise.html:65:
};;
On 2017/02/07 18:38:43, hongchan wrote:
> Two semicolons.

Done.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html
(right):

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html:37:
scheduledSuspendTime,
On 2017/02/07 18:38:43, hongchan wrote:
> Is this the result from clang-format? This is weird.

Bad indentation from js-beautify because I didn't include the if statement in
the indentation.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html:67:
should(context.state, 'oncomplete event handler:
context.state').beEqualTo('closed');
On 2017/02/07 18:38:43, hongchan wrote:
> Needs to be wrapped at 80.

Done.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html
(right):

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html:29:
scheduledSuspendTime) {
On 2017/02/07 18:38:43, hongchan wrote:
> I find this line break is weird. This should be:
> 
> if (context.state === 'suspended'
>     && context.currentTime === scheduledSuspendTime)

js-(un)beautify.  I'll reindent this with clang-format.

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/onstatechange.html
(right):

https://codereview.chromium.org/2680033002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/onstatechange.html:66:
context.onstatechange = (e) => checkStateChange(e, should);
On 2017/02/07 18:38:43, hongchan wrote:
> (event)

Done.

[hongchan, 2017-02-09 23:03:45]

lgtm with nit

https://codereview.chromium.org/2680033002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html
(right):

https://codereview.chromium.org/2680033002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html:39:
context.currentTime === scheduledSuspendTime,
This indentation is wrong. Is this done manually?

[Raymond Toy, 2017-02-09 23:13:14]

https://codereview.chromium.org/2680033002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html
(right):

https://codereview.chromium.org/2680033002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html:39:
context.currentTime === scheduledSuspendTime,
On 2017/02/09 23:03:45, hongchan wrote:
> This indentation is wrong. Is this done manually?

clang-format produces this.

[Raymond Toy, 2017-02-14 20:10:17]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-02-14 20:11:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 21:30:05]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487103017501190,
"parent_rev": "2b892c8633d4e17894340683093748d229dcd3e7", "commit_rev":
"7832d67481ad51c31126552301df007efb57fa8a"}

[commit-bot: I haz the power, 2017-02-14 21:30:38]

Description was changed from

==========
Convert OfflineAudioContext tests to testharness

Manually convert these tests to testharness and new Audit.

BUG=689076
TEST=
==========

to

==========
Convert OfflineAudioContext tests to testharness

Manually convert these tests to testharness and new Audit.

BUG=689076
TEST=

Review-Url: https://codereview.chromium.org/2680033002
Cr-Commit-Position: refs/heads/master@{#450481}
Committed:
https://chromium.googlesource.com/chromium/src/+/7832d67481ad51c31126552301df...
==========

[commit-bot: I haz the power, 2017-02-14 21:30:42]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/7832d67481ad51c31126552301df...