[GeometryInterface] add getBounds function in DOMQaud.

[GeometryInterface] add getBounds function in DOMQaud.

The getBounds() method, when invoked,
must run the following algorithm:
1.Let bounds be a DOMRect object.
2.Let left be the minimum of p1.x, p2.x, p3.x and p4.x.
3.Let top be the minimum of p1.y, p2.y, p3.y and p4.y.
4.Let right be the maximum of p1.x, p2.x, p3.x and p4.x.
5.Let bottom be the maximum of p1.y, p2.y, p3.y and p4.y.
6.Let x coordinate of bounds be left,
 y coordinate of bounds be top,
 width dimension of bounds be right - left
 and height dimension of bounds be bottom - top.
7.Return bounds.

spec list:
https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

BUG=678237
Review-Url: https://codereview.chromium.org/2680023003
Cr-Commit-Position: refs/heads/master@{#450556}
Committed: https://chromium.googlesource.com/chromium/src/+/d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508

[Hwanseung Lee, 2017-02-07 20:41:01]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 20:41:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-02-07 22:02:55]

Description was changed from

==========
[WIP] add getBounds function in DOMQaud.

The getBounds() method, when invoked,
must run the following algorithm:
1.Let bounds be a DOMRect object.
2.Let left be the minimum of p1.x, p2.x, p3.x and p4.x.
3.Let top be the minimum of p1.y, p2.y, p3.y and p4.y.
4.Let right be the maximum of p1.x, p2.x, p3.x and p4.x.
5.Let bottom be the maximum of p1.y, p2.y, p3.y and p4.y.
6.Let x coordinate of bounds be left,
 y coordinate of bounds be top,
 width dimension of bounds be right - left
 and height dimension of bounds be bottom - top.
7.Return bounds.

spec list:
https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

BUG=678237
==========

to

==========
[WIP] add getBounds function in DOMQaud.

The getBounds() method, when invoked,
must run the following algorithm:
1.Let bounds be a DOMRect object.
2.Let left be the minimum of p1.x, p2.x, p3.x and p4.x.
3.Let top be the minimum of p1.y, p2.y, p3.y and p4.y.
4.Let right be the maximum of p1.x, p2.x, p3.x and p4.x.
5.Let bottom be the maximum of p1.y, p2.y, p3.y and p4.y.
6.Let x coordinate of bounds be left,
 y coordinate of bounds be top,
 width dimension of bounds be right - left
 and height dimension of bounds be bottom - top.
7.Return bounds.

spec list:
https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

BUG=678237
==========

[Hwanseung Lee, 2017-02-07 22:03:33]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 22:04:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-02-08 00:13:46]

Description was changed from

==========
[WIP] add getBounds function in DOMQaud.

The getBounds() method, when invoked,
must run the following algorithm:
1.Let bounds be a DOMRect object.
2.Let left be the minimum of p1.x, p2.x, p3.x and p4.x.
3.Let top be the minimum of p1.y, p2.y, p3.y and p4.y.
4.Let right be the maximum of p1.x, p2.x, p3.x and p4.x.
5.Let bottom be the maximum of p1.y, p2.y, p3.y and p4.y.
6.Let x coordinate of bounds be left,
 y coordinate of bounds be top,
 width dimension of bounds be right - left
 and height dimension of bounds be bottom - top.
7.Return bounds.

spec list:
https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

BUG=678237
==========

to

==========
[GeometryInterface] add getBounds function in DOMQaud.

The getBounds() method, when invoked,
must run the following algorithm:
1.Let bounds be a DOMRect object.
2.Let left be the minimum of p1.x, p2.x, p3.x and p4.x.
3.Let top be the minimum of p1.y, p2.y, p3.y and p4.y.
4.Let right be the maximum of p1.x, p2.x, p3.x and p4.x.
5.Let bottom be the maximum of p1.y, p2.y, p3.y and p4.y.
6.Let x coordinate of bounds be left,
 y coordinate of bounds be top,
 width dimension of bounds be right - left
 and height dimension of bounds be bottom - top.
7.Return bounds.

spec list:
https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

BUG=678237
==========

[commit-bot: I haz the power, 2017-02-08 00:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:25:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Hwanseung Lee, 2017-02-08 00:26:44]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 00:27:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 01:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 01:34:34]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-02-08 01:36:12]

hs1217.lee@samsung.com changed reviewers:
+ dominicc@chromium.org, jinho.bang@samsung.com

[Hwanseung Lee, 2017-02-08 01:36:44]

@dominic, zino
PTAL, thank you.

[zino, 2017-02-13 15:23:19]

https://codereview.chromium.org/2680023003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMQuad.cpp (right):

https://codereview.chromium.org/2680023003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMQuad.cpp:34: double left =
std::min(p1()->x(), p2()->x());
This might be inefficiency. We should cache the bounds value and
just return it when calling getBounds().

[Hwanseung Lee, 2017-02-13 15:46:49]

On 2017/02/13 15:23:19, zino wrote:
>
https://codereview.chromium.org/2680023003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/DOMQuad.cpp (right):
> 
>
https://codereview.chromium.org/2680023003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/DOMQuad.cpp:34: double left =
> std::min(p1()->x(), p2()->x());
> This might be inefficiency. We should cache the bounds value and
> just return it when calling getBounds().

how about Patch Set 3? do we need caching DOMRect instead of four double
variables?

[dominicc (has gone to gerrit), 2017-02-15 01:36:11]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2017-02-15 01:36:11]

lgtm

[commit-bot: I haz the power, 2017-02-15 01:37:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[zino, 2017-02-15 01:43:05]

On 2017/02/13 15:46:49, Hwanseung Lee wrote:
> On 2017/02/13 15:23:19, zino wrote:
> >
>
https://codereview.chromium.org/2680023003/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/core/dom/DOMQuad.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2680023003/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/core/dom/DOMQuad.cpp:34: double left =
> > std::min(p1()->x(), p2()->x());
> > This might be inefficiency. We should cache the bounds value and
> > just return it when calling getBounds().
> 
> how about Patch Set 3? do we need caching DOMRect instead of four double
> variables?

I meant that the getBounds() function should return already calculated bounds
object.
We don't need to calculate its bounds whenever calling getBounds() function.

[zino, 2017-02-15 01:46:24]

Ah, okay patch set 3 is similar to my thought.
After implementing setter, we can improve it more.

lgtm

[commit-bot: I haz the power, 2017-02-15 05:25:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487122571314460,
"parent_rev": "5032c74f91a69f5ecfcdd435c1e857dbc62dd259", "commit_rev":
"d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508"}

[commit-bot: I haz the power, 2017-02-15 05:26:25]

Description was changed from

==========
[GeometryInterface] add getBounds function in DOMQaud.

The getBounds() method, when invoked,
must run the following algorithm:
1.Let bounds be a DOMRect object.
2.Let left be the minimum of p1.x, p2.x, p3.x and p4.x.
3.Let top be the minimum of p1.y, p2.y, p3.y and p4.y.
4.Let right be the maximum of p1.x, p2.x, p3.x and p4.x.
5.Let bottom be the maximum of p1.y, p2.y, p3.y and p4.y.
6.Let x coordinate of bounds be left,
 y coordinate of bounds be top,
 width dimension of bounds be right - left
 and height dimension of bounds be bottom - top.
7.Return bounds.

spec list:
https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

BUG=678237
==========

to

==========
[GeometryInterface] add getBounds function in DOMQaud.

The getBounds() method, when invoked,
must run the following algorithm:
1.Let bounds be a DOMRect object.
2.Let left be the minimum of p1.x, p2.x, p3.x and p4.x.
3.Let top be the minimum of p1.y, p2.y, p3.y and p4.y.
4.Let right be the maximum of p1.x, p2.x, p3.x and p4.x.
5.Let bottom be the maximum of p1.y, p2.y, p3.y and p4.y.
6.Let x coordinate of bounds be left,
 y coordinate of bounds be top,
 width dimension of bounds be right - left
 and height dimension of bounds be bottom - top.
7.Return bounds.

spec list:
https://drafts.fxtf.org/geometry/#dom-domquad-getbounds

BUG=678237

Review-Url: https://codereview.chromium.org/2680023003
Cr-Commit-Position: refs/heads/master@{#450556}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0ab8b3f65a2c53f1e050b808ea1...
==========

[commit-bot: I haz the power, 2017-02-15 05:26:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d0ab8b3f65a2c53f1e050b808ea1...