Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2680013010: Add strict mode exclusion around PreferenceFragment#addPreferencesFromResource (Closed)

Created:
3 years, 10 months ago by Ted C
Modified:
3 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add strict mode exclusion around PreferenceFragment#addPreferencesFromResource BUG=687321 Review-Url: https://codereview.chromium.org/2680013010 Cr-Commit-Position: refs/heads/master@{#449681} Committed: https://chromium.googlesource.com/chromium/src/+/4163c4542960b48b8d23e3ad4d0591c3c53d71f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Ted C
PTAL
3 years, 10 months ago (2017-02-10 17:37:05 UTC) #2
gone
lgtm
3 years, 10 months ago (2017-02-10 18:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680013010/1
3 years, 10 months ago (2017-02-10 18:27:50 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:08:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4163c4542960b48b8d23e3ad4d05...

Powered by Google App Engine
This is Rietveld 408576698