Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2679983003: Remove unnecessary line in PasswordManagerBrowserTestBase. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary line in PasswordManagerBrowserTestBase. This wasn't doing anything since I converted ManagePasswordsUIController to the new callback in r446997. BUG=682002 Review-Url: https://codereview.chromium.org/2679983003 Cr-Commit-Position: refs/heads/master@{#448806} Committed: https://chromium.googlesource.com/chromium/src/+/7c8679269a9b601815b4665fd95c84d9963c7c50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/password_manager/password_manager_test_base.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
jam
3 years, 10 months ago (2017-02-07 17:19:42 UTC) #8
vabr (Chromium)
LGTM, thanks. Vaclav
3 years, 10 months ago (2017-02-07 23:20:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679983003/1
3 years, 10 months ago (2017-02-07 23:58:08 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 00:06:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c8679269a9b601815b4665fd95c...

Powered by Google App Engine
This is Rietveld 408576698