customtabs: Don't resurrect a "kept alive" process that died.

customtabs: Don't resurrect a "kept alive" process that died.

When the system is really low on memory, it can kill a process that
Chrome is trying to keep alive. Alternatively, the process can die. In
this case, don't resurrect the process, as it has likely lost all state.

BUG=689673
Review-Url: https://codereview.chromium.org/2679933004
Cr-Commit-Position: refs/heads/master@{#450929}
Committed: https://chromium.googlesource.com/chromium/src/+/9bcd576d2621e7b20d8f3bf3f5c87914077ca39e

[Benoit L, 2017-02-07 22:46:13]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 22:47:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 23:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 23:30:49]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2017-02-07 23:39:27]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Benoit L, 2017-02-15 16:55:17]

ping :-)

[Yusuf, 2017-02-15 17:43:52]

lgtm with nits and a question

https://codereview.chromium.org/2679933004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
(right):

https://codereview.chromium.org/2679933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:72:

javadoc

https://codereview.chromium.org/2679933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:87:

javadoc

https://codereview.chromium.org/2679933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:90:
mContext.unbindService(this);
Will unbind still work if we are disconnected? When onServiceDisconnected calls
this won't it crash saying it is already not bound? Or binding and being
connected are technically different?

[Benoit L, 2017-02-16 10:25:52]

Thanks!

https://codereview.chromium.org/2679933004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
(right):

https://codereview.chromium.org/2679933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:72:

On 2017/02/15 17:43:52, Yusuf wrote:
> javadoc

Done.

https://codereview.chromium.org/2679933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:87:

On 2017/02/15 17:43:52, Yusuf wrote:
> javadoc

Done.

https://codereview.chromium.org/2679933004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java:90:
mContext.unbindService(this);
On 2017/02/15 17:43:51, Yusuf wrote:
> Will unbind still work if we are disconnected? When onServiceDisconnected
calls
> this won't it crash saying it is already not bound? Or binding and being
> connected are technically different?

Yes, but you cannot unbind twice, otherwise the framework will raise an
exception. When the remote service dies but the application is still bound to
it, the framework restarts it automatically.

[Benoit L, 2017-02-16 10:25:59]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2017-02-16 10:25:59]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/2679933004/#ps20001
(title: "Javadoc.")

[commit-bot: I haz the power, 2017-02-16 10:26:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 11:03:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487240759101350,
"parent_rev": "0500b5bcf767401d9af39c6f262212aacd8765ea", "commit_rev":
"9bcd576d2621e7b20d8f3bf3f5c87914077ca39e"}

[commit-bot: I haz the power, 2017-02-16 11:04:19]

Description was changed from

==========
customtabs: Don't resurrect a "kept alive" process that died.

When the system is really low on memory, it can kill a process that
Chrome is trying to keep alive. Alternatively, the process can die. In
this case, don't resurrect the process, as it has likely lost all state.

BUG=689673
==========

to

==========
customtabs: Don't resurrect a "kept alive" process that died.

When the system is really low on memory, it can kill a process that
Chrome is trying to keep alive. Alternatively, the process can die. In
this case, don't resurrect the process, as it has likely lost all state.

BUG=689673

Review-Url: https://codereview.chromium.org/2679933004
Cr-Commit-Position: refs/heads/master@{#450929}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bcd576d2621e7b20d8f3bf3f5c8...
==========

[commit-bot: I haz the power, 2017-02-16 11:04:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9bcd576d2621e7b20d8f3bf3f5c8...