[turbofan] Remove for-in support from the AstGraphBuilder.

[turbofan] Remove for-in support from the AstGraphBuilder.

The AstGraphBuilder is used for asm.js only and for-in is not allowed in
valid asm.js, so we can just disable optimization for asm.js functions
that contain for-in loops. This way we only need to support for-in via
the BytecodeGraphBuilder in TurboFan now, which will make optimizations
way easier.

R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2679913004
Cr-Commit-Position: refs/heads/master@{#43024}
Committed: https://chromium.googlesource.com/v8/v8/+/d9c091dd60eb155c29702d69f8d90a9d5844009a

[Benedikt Meurer, 2017-02-08 06:14:11]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 06:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-02-08 06:24:58]

lgtm with comment

https://codereview.chromium.org/2679913004/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2679913004/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1177: return SetStackOverflow();
In other places we simply have a UNREACHABLE(). See VisitTryFinallyStatement

[Benedikt Meurer, 2017-02-08 06:26:08]

https://codereview.chromium.org/2679913004/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2679913004/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.cc:1177: return SetStackOverflow();
We still need to handle for..in inside asm.js, and UNREACHABLE() would crash the
renderer :-)

[Benedikt Meurer, 2017-02-08 06:26:13]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-02-08 06:26:18]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-02-08 06:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-02-08 06:38:27]

On 2017/02/08 06:26:08, Benedikt Meurer wrote:
>
https://codereview.chromium.org/2679913004/diff/1/src/compiler/ast-graph-buil...
> File src/compiler/ast-graph-builder.cc (right):
> 
>
https://codereview.chromium.org/2679913004/diff/1/src/compiler/ast-graph-buil...
> src/compiler/ast-graph-builder.cc:1177: return SetStackOverflow();
> We still need to handle for..in inside asm.js, and UNREACHABLE() would crash
the
> renderer :-)

does that also apply to the TryFinallyStatement and others?

[Benedikt Meurer, 2017-02-08 06:38:52]

On 2017/02/08 06:38:27, Yang wrote:
> On 2017/02/08 06:26:08, Benedikt Meurer wrote:
> >
>
https://codereview.chromium.org/2679913004/diff/1/src/compiler/ast-graph-buil...
> > File src/compiler/ast-graph-builder.cc (right):
> > 
> >
>
https://codereview.chromium.org/2679913004/diff/1/src/compiler/ast-graph-buil...
> > src/compiler/ast-graph-builder.cc:1177: return SetStackOverflow();
> > We still need to handle for..in inside asm.js, and UNREACHABLE() would crash
> the
> > renderer :-)
> 
> does that also apply to the TryFinallyStatement and others?

No, the AstNumbering kills that.

[commit-bot: I haz the power, 2017-02-08 06:41:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486535178546670, "parent_rev":
"3c97959a7dd09b3d59501f2f6e1a4615dbad412f", "commit_rev":
"d9c091dd60eb155c29702d69f8d90a9d5844009a"}

[commit-bot: I haz the power, 2017-02-08 06:41:47]

Description was changed from

==========
[turbofan] Remove for-in support from the AstGraphBuilder.

The AstGraphBuilder is used for asm.js only and for-in is not allowed in
valid asm.js, so we can just disable optimization for asm.js functions
that contain for-in loops. This way we only need to support for-in via
the BytecodeGraphBuilder in TurboFan now, which will make optimizations
way easier.

R=yangguo@chromium.org
==========

to

==========
[turbofan] Remove for-in support from the AstGraphBuilder.

The AstGraphBuilder is used for asm.js only and for-in is not allowed in
valid asm.js, so we can just disable optimization for asm.js functions
that contain for-in loops. This way we only need to support for-in via
the BytecodeGraphBuilder in TurboFan now, which will make optimizations
way easier.

R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2679913004
Cr-Commit-Position: refs/heads/master@{#43024}
Committed:
https://chromium.googlesource.com/v8/v8/+/d9c091dd60eb155c29702d69f8d90a9d584...
==========

[commit-bot: I haz the power, 2017-02-08 06:41:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d9c091dd60eb155c29702d69f8d90a9d584...