Replace OnMemoryStateChange() with OnPurgeMemory() in net/

Replace OnMemoryStateChange() with OnPurgeMemory() in net/

When we implemented MemoryCoordinatorClients in net/, there was only one
callback called OnMemoryStateChange(). Recently we added another
callback called OnPurgeMemory() to handle "existing allocations" and
"future allocations" separately (See [1] for the motivation). This CL
replaces OnMemoryStateChange() with OnPurgeMemory() because all clients
in net/ actually free up memory.

Note: MemoryCoordinatorClient and MemoryPressureListener won't be
enabled at the same time. This means that either OnMemoryPressure() or
OnPurgeMemory() can be called.

[1] https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/project-trim/s96xSirL2Hs/18uq1zfHEgAJ

BUG=684287, 617492
Review-Url: https://codereview.chromium.org/2679903002
Cr-Commit-Position: refs/heads/master@{#449178}
Committed: https://chromium.googlesource.com/chromium/src/+/56b23f3064d47916ee13dadbbb7e87e2d15b80fd

[bashi, 2017-02-07 07:35:21]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 07:35:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-02-07 08:11:40]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, rsleevi@chromium.org

[bashi, 2017-02-07 08:11:41]

rsleevi@: haraken@ is working on adding documents right now. Would you please
review this CL to make all clients' behavior consistent?

[commit-bot: I haz the power, 2017-02-07 08:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 08:50:42]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2017-02-08 17:05:59]

LGTM thanks :)

(Sorry for the delay; reviewing the documentation CL first helped me understand
more why this was correct)

[xunjieli, 2017-02-08 17:26:51]

xunjieli@chromium.org changed reviewers:
+ xunjieli@chromium.org

[xunjieli, 2017-02-08 17:26:51]

https://codereview.chromium.org/2679903002/diff/1/net/sdch/sdch_owner.h
File net/sdch/sdch_owner.h (right):

https://codereview.chromium.org/2679903002/diff/1/net/sdch/sdch_owner.h#newco...
net/sdch/sdch_owner.h:166: void OnMemoryPressure(
These three classes all subscribe to MemoryPressureListener as well. 
I suppose OnMemoryPressure() and OnPurgeMemory() won't be called at the same
time? Can you link a bug number here and mention the fact that
MemoryPressureListener is being deprecated?

[Ryan Sleevi, 2017-02-08 17:27:37]

On 2017/02/08 17:26:51, xunjieli wrote:
> https://codereview.chromium.org/2679903002/diff/1/net/sdch/sdch_owner.h
> File net/sdch/sdch_owner.h (right):
> 
>
https://codereview.chromium.org/2679903002/diff/1/net/sdch/sdch_owner.h#newco...
> net/sdch/sdch_owner.h:166: void OnMemoryPressure(
> These three classes all subscribe to MemoryPressureListener as well. 
> I suppose OnMemoryPressure() and OnPurgeMemory() won't be called at the same
> time? Can you link a bug number here and mention the fact that
> MemoryPressureListener is being deprecated?

https://codereview.chromium.org/2678323002/ includes the review for improving
the documentation related to these interfaces

[bashi, 2017-02-08 23:40:51]

Description was changed from

==========
Replace OnMemoryStateChange() with OnPurgeMemory() in net/

When we implemented MemoryCoordinatorClients in net/, there was only one
callback called OnMemoryStateChange(). Recently we added another
callback called OnPurgeMemory() to handle "existing allocations" and
"future allocations" separately (See [1] for the motivation). This CL
replaces OnMemoryStateChange() with OnPurgeMemory() because all clients
in net/ actually free up memory.

[1]
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

BUG=684287
==========

to

==========
Replace OnMemoryStateChange() with OnPurgeMemory() in net/

When we implemented MemoryCoordinatorClients in net/, there was only one
callback called OnMemoryStateChange(). Recently we added another
callback called OnPurgeMemory() to handle "existing allocations" and
"future allocations" separately (See [1] for the motivation). This CL
replaces OnMemoryStateChange() with OnPurgeMemory() because all clients
in net/ actually free up memory.

[1]
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

BUG=684287,617492
==========

[bashi, 2017-02-08 23:52:16]

Description was changed from

==========
Replace OnMemoryStateChange() with OnPurgeMemory() in net/

When we implemented MemoryCoordinatorClients in net/, there was only one
callback called OnMemoryStateChange(). Recently we added another
callback called OnPurgeMemory() to handle "existing allocations" and
"future allocations" separately (See [1] for the motivation). This CL
replaces OnMemoryStateChange() with OnPurgeMemory() because all clients
in net/ actually free up memory.

[1]
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

BUG=684287,617492
==========

to

==========
Replace OnMemoryStateChange() with OnPurgeMemory() in net/

When we implemented MemoryCoordinatorClients in net/, there was only one
callback called OnMemoryStateChange(). Recently we added another
callback called OnPurgeMemory() to handle "existing allocations" and
"future allocations" separately (See [1] for the motivation). This CL
replaces OnMemoryStateChange() with OnPurgeMemory() because all clients
in net/ actually free up memory.

Note: MemoryCoordinatorClient and MemoryPressureListener won't be
enabled at the same time. This means that either OnMemoryPressure() or
OnPurgeMemory() can be called.

[1]
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

BUG=684287,617492
==========

[bashi, 2017-02-08 23:53:09]

On 2017/02/08 17:27:37, Ryan Sleevi wrote:
> On 2017/02/08 17:26:51, xunjieli wrote:
> > https://codereview.chromium.org/2679903002/diff/1/net/sdch/sdch_owner.h
> > File net/sdch/sdch_owner.h (right):
> > 
> >
>
https://codereview.chromium.org/2679903002/diff/1/net/sdch/sdch_owner.h#newco...
> > net/sdch/sdch_owner.h:166: void OnMemoryPressure(
> > These three classes all subscribe to MemoryPressureListener as well. 
> > I suppose OnMemoryPressure() and OnPurgeMemory() won't be called at the same
> > time? Can you link a bug number here and mention the fact that
> > MemoryPressureListener is being deprecated?
> 
> https://codereview.chromium.org/2678323002/ includes the review for improving
> the documentation related to these interfaces

Thanks Ryan for the follow-up! I've updated the description.

[bashi, 2017-02-08 23:53:27]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:54:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-09 00:51:11]

LGTM

[commit-bot: I haz the power, 2017-02-09 01:25:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486598007881380, "parent_rev":
"54d1a002919e822ff0f59fa6670bd4fc62b5fe30", "commit_rev":
"56b23f3064d47916ee13dadbbb7e87e2d15b80fd"}

[commit-bot: I haz the power, 2017-02-09 01:26:38]

Description was changed from

==========
Replace OnMemoryStateChange() with OnPurgeMemory() in net/

When we implemented MemoryCoordinatorClients in net/, there was only one
callback called OnMemoryStateChange(). Recently we added another
callback called OnPurgeMemory() to handle "existing allocations" and
"future allocations" separately (See [1] for the motivation). This CL
replaces OnMemoryStateChange() with OnPurgeMemory() because all clients
in net/ actually free up memory.

Note: MemoryCoordinatorClient and MemoryPressureListener won't be
enabled at the same time. This means that either OnMemoryPressure() or
OnPurgeMemory() can be called.

[1]
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

BUG=684287,617492
==========

to

==========
Replace OnMemoryStateChange() with OnPurgeMemory() in net/

When we implemented MemoryCoordinatorClients in net/, there was only one
callback called OnMemoryStateChange(). Recently we added another
callback called OnPurgeMemory() to handle "existing allocations" and
"future allocations" separately (See [1] for the motivation). This CL
replaces OnMemoryStateChange() with OnPurgeMemory() because all clients
in net/ actually free up memory.

Note: MemoryCoordinatorClient and MemoryPressureListener won't be
enabled at the same time. This means that either OnMemoryPressure() or
OnPurgeMemory() can be called.

[1]
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

BUG=684287,617492

Review-Url: https://codereview.chromium.org/2679903002
Cr-Commit-Position: refs/heads/master@{#449178}
Committed:
https://chromium.googlesource.com/chromium/src/+/56b23f3064d47916ee13dadbbb7e...
==========

[commit-bot: I haz the power, 2017-02-09 01:26:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56b23f3064d47916ee13dadbbb7e...