Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2679883002: Move some tests in fast/html/ to html/{document-metadata,grouping-content,text-level-semantics}/. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some tests in fast/html/ to html/{document-metadata,grouping-content,text-level-semantics}/. BUG=685886 TBR=kochi@chromium.org Review-Url: https://codereview.chromium.org/2679883002 Cr-Commit-Position: refs/heads/master@{#448569} Committed: https://chromium.googlesource.com/chromium/src/+/053af7e797b3fafb6bc03b85b189c26b3073a3b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-33 lines, -710 lines) Patch
D third_party/WebKit/LayoutTests/fast/html/a-click.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/a-tooltip.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/a-tooltip-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/a-tooltip-null.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/a-tooltip-null-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/disable-style-element.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/disable-style-element-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/empty-q-crash.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/empty-q-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/figcaption-element.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/figcaption-element-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/figure-element.html View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/figure-element-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/font-weight-bold-for-b-and-strong.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/link-clear-sheet-crash.html View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/link-clear-sheet-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/link-rel-stylesheet.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/listing.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/main-element.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/main-element-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/mark-element.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/mark-element-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/reversed-ol.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/html/reversed-ol-expected.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/document-metadata/link-clear-sheet-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/document-metadata/link-clear-sheet-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/document-metadata/link-rel-stylesheet.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/document-metadata/style-disabled.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/document-metadata/style-disabled-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/grouping-content/figcaption-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/grouping-content/figcaption-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/grouping-content/figure-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/grouping-content/figure-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/grouping-content/listing.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/grouping-content/main-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/grouping-content/main-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/a-click.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/a-tooltip.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/a-tooltip-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/a-tooltip-null.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/a-tooltip-null-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/font-weight-bold-for-b-and-strong.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/mark-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/mark-element-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/ol-reversed.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/ol-reversed-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/q-empty-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/html/text-level-semantics/q-empty-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/html/font-weight-bold-for-b-and-strong-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/html/font-weight-bold-for-b-and-strong-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/html/link-rel-stylesheet-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/html/link-rel-stylesheet-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/html/listing-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/html/listing-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/html/document-metadata/link-rel-stylesheet-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/html/document-metadata/link-rel-stylesheet-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/html/grouping-content/listing-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/html/grouping-content/listing-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/html/text-level-semantics/font-weight-bold-for-b-and-strong-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/html/text-level-semantics/font-weight-bold-for-b-and-strong-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/html/listing-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.10/html/grouping-content/listing-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/html/font-weight-bold-for-b-and-strong-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/html/font-weight-bold-for-b-and-strong-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/html/link-rel-stylesheet-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/html/link-rel-stylesheet-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/html/listing-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/html/listing-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/html/document-metadata/link-rel-stylesheet-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/html/document-metadata/link-rel-stylesheet-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/html/grouping-content/listing-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/html/grouping-content/listing-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/html/text-level-semantics/font-weight-bold-for-b-and-strong-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac/html/text-level-semantics/font-weight-bold-for-b-and-strong-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/html/font-weight-bold-for-b-and-strong-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/html/font-weight-bold-for-b-and-strong-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/html/link-rel-stylesheet-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/html/link-rel-stylesheet-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/html/listing-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/html/listing-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/html/document-metadata/link-rel-stylesheet-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/html/document-metadata/link-rel-stylesheet-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/html/grouping-content/listing-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/html/grouping-content/listing-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/html/text-level-semantics/font-weight-bold-for-b-and-strong-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/html/text-level-semantics/font-weight-bold-for-b-and-strong-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tkent
3 years, 10 months ago (2017-02-07 08:12:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679883002/1
3 years, 10 months ago (2017-02-07 08:13:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/053af7e797b3fafb6bc03b85b189c26b3073a3b4
3 years, 10 months ago (2017-02-07 08:18:57 UTC) #10
kochi
3 years, 10 months ago (2017-02-07 08:27:35 UTC) #11
Message was sent while issue was closed. 
rs lgtm

Powered by Google App Engine
This is Rietveld 408576698