Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2679823002: [Merge to M57] ChromeVox: Disable following a11y events after screen off alert is received (Closed)

Created:
3 years, 10 months ago by Qiang(Joe) Xu
Modified:
3 years, 10 months ago
Reviewers:
James Cook, David Tseng
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge to M57] ChromeVox: Disable following a11y events after screen off alert is received TBR=jamescook@chromium.org, dtseng@chromium.org BUG=686899 TEST=turning the screen off works fine. For turning the screen on, the "alert screen on" is missing if chromvox needs to talk back the screen focus for the first time. Review-Url: https://codereview.chromium.org/2676563003 Cr-Commit-Position: refs/heads/master@{#448324} (cherry picked from commit 38b110ec3981062d81c3e61a3a0508eee0f2f1c2) Review-Url: https://codereview.chromium.org/2679823002 . Cr-Commit-Position: refs/branch-heads/2987@{#352} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/6c6c221e6b72bcb4c38463fa22d5c8b0db0415f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 10 months ago (2017-02-07 00:33:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c6c221e6b72bcb4c38463fa22d5c8b0db0415f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698