Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2679813002: Disabling flaky OpenSingleVideoOnDrive on ChromeOS (Closed)

Created:
3 years, 10 months ago by joedow
Modified:
3 years, 10 months ago
Reviewers:
tapted, yoshiki
CC:
chromium-reviews, posciak+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling flaky OpenSingleVideoOnDrive on ChromeOS TBR=tapted,yoshiki BUG=688568, 508949 Review-Url: https://codereview.chromium.org/2679813002 Cr-Commit-Position: refs/heads/master@{#448477} Committed: https://chromium.googlesource.com/chromium/src/+/9fe5a71d5a272c9f81cd24eacbe8ea0ffa1ed36a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/chromeos/file_manager/video_player_browsertest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679813002/1
3 years, 10 months ago (2017-02-06 23:41:56 UTC) #2
tapted
lgtm with the following stuff, but also not critical https://codereview.chromium.org/2679813002/diff/1/chrome/browser/chromeos/file_manager/video_player_browsertest.cc File chrome/browser/chromeos/file_manager/video_player_browsertest.cc (right): https://codereview.chromium.org/2679813002/diff/1/chrome/browser/chromeos/file_manager/video_player_browsertest.cc#newcode58 chrome/browser/chromeos/file_manager/video_player_browsertest.cc:58: ...
3 years, 10 months ago (2017-02-06 23:59:23 UTC) #3
joedow
Thanks! https://codereview.chromium.org/2679813002/diff/1/chrome/browser/chromeos/file_manager/video_player_browsertest.cc File chrome/browser/chromeos/file_manager/video_player_browsertest.cc (right): https://codereview.chromium.org/2679813002/diff/1/chrome/browser/chromeos/file_manager/video_player_browsertest.cc#newcode58 chrome/browser/chromeos/file_manager/video_player_browsertest.cc:58: // CHROME_OS: http://crbug 688568 On 2017/02/06 23:59:23, tapted ...
3 years, 10 months ago (2017-02-07 00:11:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679813002/20001
3 years, 10 months ago (2017-02-07 00:12:41 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 00:55:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9fe5a71d5a272c9f81cd24eacbe8...

Powered by Google App Engine
This is Rietveld 408576698