Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2679793002: [Windows CFG Test] Added unittest for CFG enabling on process. (Closed)

Created:
3 years, 10 months ago by penny
Modified:
3 years, 10 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, pennymac+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Windows CFG Test] Added unittest for CFG enabling on process. Test ensures our build system enables CFG for a process when asked. Ensures that an MS system DLL in the process space is protected, even if none of Chromium code is compiled with CFG. TEST=New test CFGSupportTests.MsIndirectFailure in sbox_integration_tests suite. R=wfh BUG=584575 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2679793002 Cr-Commit-Position: refs/heads/master@{#450498} Committed: https://chromium.googlesource.com/chromium/src/+/8c67aad851ba03a83144557abfb2d4b3d182095e

Patch Set 1 #

Patch Set 2 : Fixing 'git cl format' breakage. #

Total comments: 12

Patch Set 3 : Code review fixes, part 1. #

Patch Set 4 : Fixed swarmed test. #

Total comments: 4

Patch Set 5 : Code review fixes, part 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -2 lines) Patch
M sandbox/win/BUILD.gn View 1 2 3 2 chunks +21 lines, -2 lines 0 comments Download
A sandbox/win/tests/integration_tests/cfi_unittest.cc View 1 2 3 4 1 chunk +53 lines, -0 lines 0 comments Download
A sandbox/win/tests/integration_tests/cfi_unittest_exe.cc View 1 2 1 chunk +295 lines, -0 lines 0 comments Download
A sandbox/win/tests/readme.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (19 generated)
penny
On 2017/02/06 21:37:44, penny wrote: > mailto:pennymac@chromium.org changed reviewers: > + mailto:wfh@chromium.org Hey Will, Would ...
3 years, 10 months ago (2017-02-06 21:44:26 UTC) #9
Will Harris
A few initial comments in general I'd like to see more comments in the test ...
3 years, 10 months ago (2017-02-06 22:33:36 UTC) #12
penny
Thanks! Fixes uploaded. https://codereview.chromium.org/2679793002/diff/20001/sandbox/win/BUILD.gn File sandbox/win/BUILD.gn (right): https://codereview.chromium.org/2679793002/diff/20001/sandbox/win/BUILD.gn#newcode212 sandbox/win/BUILD.gn:212: executable("cfi_unittest_exe") { On 2017/02/06 22:33:36, Will ...
3 years, 10 months ago (2017-02-07 23:12:56 UTC) #15
penny
On 2017/02/07 23:12:56, penny wrote: > Thanks! Fixes uploaded. > > https://codereview.chromium.org/2679793002/diff/20001/sandbox/win/BUILD.gn > File sandbox/win/BUILD.gn ...
3 years, 10 months ago (2017-02-07 23:39:52 UTC) #16
Will Harris
this is very good test. lgtm with a few comments. https://codereview.chromium.org/2679793002/diff/120001/sandbox/win/tests/integration_tests/cfi_unittest.cc File sandbox/win/tests/integration_tests/cfi_unittest.cc (right): https://codereview.chromium.org/2679793002/diff/120001/sandbox/win/tests/integration_tests/cfi_unittest.cc#newcode14 ...
3 years, 10 months ago (2017-02-10 22:38:47 UTC) #18
penny
Thanks for the review Will! https://codereview.chromium.org/2679793002/diff/120001/sandbox/win/tests/integration_tests/cfi_unittest.cc File sandbox/win/tests/integration_tests/cfi_unittest.cc (right): https://codereview.chromium.org/2679793002/diff/120001/sandbox/win/tests/integration_tests/cfi_unittest.cc#newcode14 sandbox/win/tests/integration_tests/cfi_unittest.cc:14: const wchar_t* kExeFilename = ...
3 years, 10 months ago (2017-02-13 18:47:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679793002/140001
3 years, 10 months ago (2017-02-13 18:47:43 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng/builds/685)
3 years, 10 months ago (2017-02-13 23:48:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679793002/140001
3 years, 10 months ago (2017-02-14 20:55:29 UTC) #26
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 22:46:18 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/8c67aad851ba03a83144557abfb2...

Powered by Google App Engine
This is Rietveld 408576698