Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2679643003: macviews: unhook task manager from --secondary-ui-md (Closed)

Created:
3 years, 10 months ago by Elly Fong-Jones
Modified:
3 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macviews: unhook task manager from --secondary-ui-md The task manager won't be included when we ship MacViews. BUG=689085 Review-Url: https://codereview.chromium.org/2679643003 Cr-Commit-Position: refs/heads/master@{#448615} Committed: https://chromium.googlesource.com/chromium/src/+/9b6ffe796dc5188894fa9a69bd7696a598ce5b1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/ui/cocoa/task_manager_mac.mm View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Elly Fong-Jones
thakis: ptal? :)
3 years, 10 months ago (2017-02-06 20:11:53 UTC) #5
Nico
lgtm The bug asks for its own flag for the task manager which this doesn't ...
3 years, 10 months ago (2017-02-06 22:27:21 UTC) #8
Elly Fong-Jones
On 2017/02/06 22:27:21, Nico wrote: > lgtm > > The bug asks for its own ...
3 years, 10 months ago (2017-02-07 14:01:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679643003/1
3 years, 10 months ago (2017-02-07 14:01:54 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 14:06:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b6ffe796dc5188894fa9a69bd76...

Powered by Google App Engine
This is Rietveld 408576698