Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2679623002: Clear MatchedPropertiesCache on StyleRule changes. (Closed)

Created:
3 years, 10 months ago by rune
Modified:
3 years, 10 months ago
Reviewers:
meade_UTC10, sashab
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear MatchedPropertiesCache on StyleRule changes. CSSOM changes used to cause a FullStyleUpdate which cleared the whole StyleResolver. With the new active stylesheet update using RuleSet- based style invalidation, clearing the MatchedPropertiesCache was missing. The reason it needs to be cleared, is that the hash key for the cache entry is based on StylePropertySet pointers which don't change when adding/removing declarations to a mutable StylePropertySet. R=meade@chromium.org BUG=681183 Review-Url: https://codereview.chromium.org/2679623002 Cr-Commit-Position: refs/heads/master@{#448939} Committed: https://chromium.googlesource.com/chromium/src/+/8c00af2b243ead60e3d7011b5a85367735f19ba1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rune
ptal
3 years, 10 months ago (2017-02-06 12:52:10 UTC) #5
rune
3 years, 10 months ago (2017-02-07 23:04:07 UTC) #7
meade_UTC10
lgtm
3 years, 10 months ago (2017-02-08 07:57:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679623002/1
3 years, 10 months ago (2017-02-08 08:22:19 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 10:00:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c00af2b243ead60e3d7011b5a85...

Powered by Google App Engine
This is Rietveld 408576698