Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2679573002: Convert ExtensionMessagePort::FrameTracker to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ExtensionMessagePort::FrameTracker to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2679573002 Cr-Commit-Position: refs/heads/master@{#448270} Committed: https://chromium.googlesource.com/chromium/src/+/ae35030e907ce6986123b73f10323f1c3e9672ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/extensions/api/messaging/extension_message_port.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
jam
3 years, 10 months ago (2017-02-06 15:43:39 UTC) #8
Devlin
lgtm
3 years, 10 months ago (2017-02-06 15:54:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679573002/20001
3 years, 10 months ago (2017-02-06 16:27:46 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 16:35:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae35030e907ce6986123b73f1032...

Powered by Google App Engine
This is Rietveld 408576698