Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2679563003: Remove the ugly focus outline of the keyboard overlay instructions (Closed)

Created:
3 years, 10 months ago by afakhry
Modified:
3 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the ugly focus outline of the keyboard overlay instructions The instructions div of the keyboard overlay is programmaticllay focused when the widget is shown to enable chrome vox to read it the first thing, however the default style of a focused element is to show an ugly orange outline around it. This CL removes that outline. BUG=688016 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2679563003 Cr-Commit-Position: refs/heads/master@{#448433} Committed: https://chromium.googlesource.com/chromium/src/+/ccfadbad03c399f42543a9ea45d1748a85278216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/keyboard_overlay.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
afakhry
Xiyuan, could you please review this CL? Thanks!
3 years, 10 months ago (2017-02-06 19:05:46 UTC) #3
xiyuan
lgtm
3 years, 10 months ago (2017-02-06 21:48:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679563003/1
3 years, 10 months ago (2017-02-06 21:54:43 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 23:07:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ccfadbad03c399f42543a9ea45d1...

Powered by Google App Engine
This is Rietveld 408576698