Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Issue 2679553006: Include VisualViewport layers in layerTreeAsText output. (Closed)

Created:
3 years, 10 months ago by skobes
Modified:
3 years, 10 months ago
Reviewers:
bokan
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include VisualViewport layers in layerTreeAsText output. In the main frame, the LayerTreeIncludesRootLayer flag will now begin at the root of the GraphicsLayer tree. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2679553006 Cr-Commit-Position: refs/heads/master@{#448801} Committed: https://chromium.googlesource.com/chromium/src/+/d5cb3ac6f4158978f17e9f0999f4a5e54f9c7478

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/compositing/fixed-body-background-positioned-expected.txt View 1 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
skobes
3 years, 10 months ago (2017-02-07 20:18:41 UTC) #10
bokan
lgtm
3 years, 10 months ago (2017-02-07 21:09:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679553006/20001
3 years, 10 months ago (2017-02-07 21:48:59 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:54:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d5cb3ac6f4158978f17e9f0999f4...

Powered by Google App Engine
This is Rietveld 408576698