Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: chrome/browser/ui/views/webshare/webshare_target_picker_view.cc

Issue 2679533002: Added unit test for WebShareTargetPickerView. (Closed)
Patch Set: Test selection and double-click logic. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
diff --git a/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc b/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
index 5bc5a97035912945e86bedae504fa5ef1153625b..a38b65b34177cbe6236e548129d1b886ab3dfe9b 100644
--- a/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
+++ b/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
@@ -131,7 +131,10 @@ bool WebShareTargetPickerView::Cancel() {
bool WebShareTargetPickerView::Accept() {
if (!close_callback_.is_null()) {
- DCHECK(!table_->selection_model().empty());
+ // If nothing is selected, can't accept.
+ if (table_->selection_model().empty())
sky 2017/02/08 17:03:44 How do we end up here with an empty selection? Doe
sky 2017/02/08 17:06:51 I suspect this is because your test is directly ca
Matt Giuca 2017/02/08 23:26:42 Oh OK, I wasn't sure if that was guaranteed or if
+ return false;
+
close_callback_.Run(targets_[table_->FirstSelectedRow()].second.spec());
}

Powered by Google App Engine
This is Rietveld 408576698