Added unit test for WebShareTargetPickerView.

chrome/browser/ui/views/webshare/webshare_target_picker_view.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/webshare/webshare_target_picker_view.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/constrained_window/constrained_window_views.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 113 matching lines @@
 
 bool WebShareTargetPickerView::Cancel() {
   if (!close_callback_.is_null())
     close_callback_.Run(base::nullopt);
 
   return true;
 }
 
 bool WebShareTargetPickerView::Accept() {
   if (!close_callback_.is_null()) {
-    DCHECK(!table_->selection_model().empty());
+    // If nothing is selected, can't accept.
+    if (table_->selection_model().empty())

[sky, 2017/02/08 17:03:44]

How do we end up here with an empty selection? Doesn't the
IsDialogButtonEnabled() override below make it so accept isn't called when there
isn't a selection?

[sky, 2017/02/08 17:06:51]

I suspect this is because your test is directly calling OnDoubleClick. TableView
only calls OnDoubleClick if there is a selection. I think the DCHECK should
remain and the test should be updated.

[Matt Giuca, 2017/02/08 23:26:42]

Oh OK, I wasn't sure if that was guaranteed or if there was a way for
OnDoubleClick to be triggered when there wasn't a selection. So I'll simply
remove the test of double-clicking while there is no selection (under the
assumption that that can never happen).

+      return false;
+
     close_callback_.Run(targets_[table_->FirstSelectedRow()].second.spec());
   }
 
   return true;
 }
 
 base::string16 WebShareTargetPickerView::GetDialogButtonLabel(
     ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_OK)
     return l10n_util::GetStringUTF16(IDS_WEBSHARE_TARGET_PICKER_COMMIT);
@@ skipping 10 matching lines @@
   return true;
 }
 
 void WebShareTargetPickerView::OnSelectionChanged() {
   GetDialogClientView()->UpdateDialogButtons();
 }
 
 void WebShareTargetPickerView::OnDoubleClick() {
   GetDialogClientView()->AcceptWindow();
 }