Added unit test for WebShareTargetPickerView.

chrome/browser/ui/views/webshare/webshare_target_picker_view.cc

Index: chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
diff --git a/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc b/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
index 5bc5a97035912945e86bedae504fa5ef1153625b..a38b65b34177cbe6236e548129d1b886ab3dfe9b 100644
--- a/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
+++ b/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
@@ -131,7 +131,10 @@ bool WebShareTargetPickerView::Cancel() {
 
 bool WebShareTargetPickerView::Accept() {
   if (!close_callback_.is_null()) {
-    DCHECK(!table_->selection_model().empty());
+    // If nothing is selected, can't accept.
+    if (table_->selection_model().empty())

[sky, 2017/02/08 17:03:44]

How do we end up here with an empty selection? Doesn't the
IsDialogButtonEnabled() override below make it so accept isn't called when there
isn't a selection?

[sky, 2017/02/08 17:06:51]

I suspect this is because your test is directly calling OnDoubleClick. TableView
only calls OnDoubleClick if there is a selection. I think the DCHECK should
remain and the test should be updated.

[Matt Giuca, 2017/02/08 23:26:42]

Oh OK, I wasn't sure if that was guaranteed or if there was a way for
OnDoubleClick to be triggered when there wasn't a selection. So I'll simply
remove the test of double-clicking while there is no selection (under the
assumption that that can never happen).

+      return false;
+
     close_callback_.Run(targets_[table_->FirstSelectedRow()].second.spec());
   }