DevTools: Create extensible QuickOpen control

third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
index 8f39d886e0eac9dcde3761cf3a684657bf9c0547..ec2842d174c8d6e6f037c63b9f8b90149516a904 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
@@ -602,26 +602,12 @@ Sources.SourcesView = class extends UI.VBox {
   }
 
   /**
-   * @param {string=} query
-   */
-  showOpenResourceDialog(query) {
-    var uiSourceCodes = this._editorContainer.historyUISourceCodes();
-    /** @type {!Map.<!Workspace.UISourceCode, number>} */
-    var defaultScores = new Map();
-    for (var i = 1; i < uiSourceCodes.length; ++i)  // Skip current element
-      defaultScores.set(uiSourceCodes[i], uiSourceCodes.length - i);
-    if (!this._openResourceDialogHistory)
-      this._openResourceDialogHistory = [];
-    Sources.OpenResourceDialog.show(this, query || '', defaultScores, this._openResourceDialogHistory);
-  }
-
-  /**
    * @param {!Event=} event
    * @return {boolean}
    */
   _showGoToLineDialog(event) {

[pfeldman, 2017/02/07 02:10:03]

Extract this into an action in its own class (Sources.SourcesPanel.GoToHandler?)
where ever provider for ":" is.

[einbinder, 2017/02/28 23:59:07]

Would it use flavor(SourcesView) to check if the editor has a current file?

     if (this._editorContainer.currentFile())
-      this.showOpenResourceDialog(':');
+      QuickOpen.QuickOpen.show(':');
     return true;
   }
 
@@ -674,6 +660,21 @@ Sources.SourcesView = class extends UI.VBox {
   toggleBreakpointsActiveState(active) {
     this._editorContainer.view.element.classList.toggle('breakpoints-deactivated', !active);
   }
+
+  /**
+   * @return {!Map.<!Workspace.UISourceCode, number>}
+   */
+  static defaultUISourceCodeScores() {

[pfeldman, 2017/02/07 02:10:03]

Declare static members first

[einbinder, 2017/02/28 23:59:07]

Done.

+    /** @type {!Map.<!Workspace.UISourceCode, number>} */
+    var defaultScores = new Map();
+    var sourcesView = UI.context.flavor(Sources.SourcesView);

[pfeldman, 2017/02/07 02:10:03]

Don't abuse context - all setters and getters of this flavor are in this class.
Just make it a singleton for now.

[einbinder, 2017/02/28 23:59:07]

A singleton feels weird because it operates on a visible SourcesView. But would
you want every user of SourcesView flavor to switch to the singleton, or just
this one? GoToLine uses it to get the current UISourceCode.

+    if (sourcesView) {
+      var uiSourceCodes = sourcesView._editorContainer.historyUISourceCodes();
+      for (var i = 1; i < uiSourceCodes.length; ++i)  // Skip current element
+        defaultScores.set(uiSourceCodes[i], uiSourceCodes.length - i);
+    }
+    return defaultScores;
+  }
 };
 
 /** @enum {symbol} */