DevTools: Create extensible QuickOpen control

third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js

Index: third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js b/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
index 72be08cda8f1ee091f528e930025a7be419c0a0f..70df9b7ca4043d3a35957cff8fe7facedb16a328 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
@@ -8,32 +8,12 @@
  * @unrestricted
  */
 Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListDelegate {

[pfeldman, 2017/02/07 02:10:03]

This is no longer a dialog, lets call it Sources.OpenFileQuickOpen ?

[einbinder, 2017/02/28 23:59:07]

Done.

-  /**
-   * @param {!Sources.SourcesView} sourcesView
-   * @param {!Map.<!Workspace.UISourceCode, number>} defaultScores
-   */
-  constructor(sourcesView, defaultScores) {
-    super(defaultScores);
-    this._sourcesView = sourcesView;
+  constructor() {
+    super(Sources.SourcesView.defaultUISourceCodeScores());
     this.populate();
   }
 
   /**
-   * @param {!Sources.SourcesView} sourcesView
-   * @param {string} query
-   * @param {!Map.<!Workspace.UISourceCode, number>} defaultScores
-   * @param {!Array<string>} history
-   */
-  static show(sourcesView, query, defaultScores, history) {
-    var dialog = new Sources.OpenResourceDialog(sourcesView, defaultScores);
-    if (InspectorFrontendHost.isUnderTest())
-      Sources.OpenResourceDialog._instanceForTest = dialog;
-    var filteredItemSelectionDialog = new QuickOpen.FilteredListWidget(dialog, history);
-    filteredItemSelectionDialog.showAsDialog();
-    filteredItemSelectionDialog.setQuery(query);
-  }
-
-  /**
    * @override
    * @param {?Workspace.UISourceCode} uiSourceCode
    * @param {number=} lineNumber
@@ -41,19 +21,8 @@ Sources.OpenResourceDialog = class extends Sources.FilteredUISourceCodeListDeleg
    */
   uiSourceCodeSelected(uiSourceCode, lineNumber, columnNumber) {
     if (!uiSourceCode)
-      uiSourceCode = this._sourcesView.currentUISourceCode();
-    if (!uiSourceCode)
       return;
-    this._sourcesView.showSourceLocation(uiSourceCode, lineNumber, columnNumber);
-  }
-
-  /**
-   * @override
-   * @param {string} query
-   * @return {boolean}
-   */
-  shouldShowMatchingItems(query) {
-    return !query.startsWith(':');
+    Common.Revealer.reveal(uiSourceCode.uiLocation((lineNumber || 0), columnNumber));
   }
 
   /**