Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2679453002:
MD Settings: CrOS: Use correct profile for Guest mode content settings (Closed)
DescriptionMD Settings: CrOS: Use correct profile for Guest mode content settings
BUG=688485
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2679453002
Cr-Commit-Position: refs/heads/master@{#449065}
Committed: https://chromium.googlesource.com/chromium/src/+/ab4fd5606a3e356af62c45588f2dcf00da8ff77c
Patch Set 1 #
Total comments: 4
Patch Set 2 : Fix comment #Patch Set 3 : Fix unittests #
Messages
Total messages: 22 (12 generated)
stevenjb@chromium.org changed reviewers: + dbeam@chromium.org, dschuyler@chromium.org
lgtm but worth writing a test?
LGTM, though I think the comment could be touched up. https://codereview.chromium.org/2679453002/diff/1/chrome/browser/ui/webui/set... File chrome/browser/ui/webui/settings/site_settings_handler.cc (right): https://codereview.chromium.org/2679453002/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/site_settings_handler.cc:383: // ChromeOS special case : in Guest mode settings are opened in Incognito nit: no space before colon here ("case:"). (Oh, and maybe a comma after "in Guest mode,". https://codereview.chromium.org/2679453002/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/site_settings_handler.cc:384: // mode, so we need original profile to actually modify settings. ? "need the original"
Description was changed from ========== MD Settings: CrOS: Use correct profile for Guest mode content settings BUG=688485 ========== to ========== MD Settings: CrOS: Use correct profile for Guest mode content settings BUG=688485 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #2 (id:20001) has been deleted
I looked into writing a unit test for this, but it would require testing the actual cookies behavior in order to be valuable, which realistically means adding a fairly complex browser test. https://codereview.chromium.org/2679453002/diff/1/chrome/browser/ui/webui/set... File chrome/browser/ui/webui/settings/site_settings_handler.cc (right): https://codereview.chromium.org/2679453002/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/site_settings_handler.cc:383: // ChromeOS special case : in Guest mode settings are opened in Incognito On 2017/02/06 20:19:19, dschuyler wrote: > nit: no space before colon here ("case:"). > (Oh, and maybe a comma after "in Guest mode,". Done. (I copy/pasted this) https://codereview.chromium.org/2679453002/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/site_settings_handler.cc:384: // mode, so we need original profile to actually modify settings. On 2017/02/06 20:19:19, dschuyler wrote: > ? "need the original" Done.
The CQ bit was checked by stevenjb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dschuyler@chromium.org, dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2679453002/#ps40001 (title: "Fix comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by stevenjb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dschuyler@chromium.org, dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2679453002/#ps60001 (title: "Fix unittests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by stevenjb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486581504638570,
"parent_rev": "3d62ffd98b8739d42ac7cd34cd4e04be35929f62", "commit_rev":
"ab4fd5606a3e356af62c45588f2dcf00da8ff77c"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: CrOS: Use correct profile for Guest mode content settings BUG=688485 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: CrOS: Use correct profile for Guest mode content settings BUG=688485 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2679453002 Cr-Commit-Position: refs/heads/master@{#449065} Committed: https://chromium.googlesource.com/chromium/src/+/ab4fd5606a3e356af62c45588f2d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/ab4fd5606a3e356af62c45588f2d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
