Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2679423004: Remove unused lambda capture in browser_presentation_connection_proxy_unittest. (Closed)

Created:
3 years, 10 months ago by krasin1
Modified:
3 years, 10 months ago
Reviewers:
mark a. foltz
CC:
chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused lambda capture in browser_presentation_connection_proxy_unittest. Clang just got a new warning about unused lambda captures, and that requires us to clean all places with this issue across all the Chromium code base. This CL fixes all such cases in //chrome, //services/ui and //ui. An example of a code that is no longer considered normal is auto g = [i, j]() { printf("%d\n", i); }; in which j is never used in the lambda and therefore its capture is unnecessary. BUG=681136 Review-Url: https://codereview.chromium.org/2679423004 Cr-Commit-Position: refs/heads/master@{#449120} Committed: https://chromium.googlesource.com/chromium/src/+/d5c9128c3d52b14e61e82279963348fdf0b07a83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/media/router/browser_presentation_connection_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
krasin1
3 years, 10 months ago (2017-02-08 21:40:20 UTC) #2
mark a. foltz
lgtm
3 years, 10 months ago (2017-02-08 21:47:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679423004/1
3 years, 10 months ago (2017-02-08 21:48:07 UTC) #8
krasin1
On 2017/02/08 21:48:07, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago (2017-02-08 21:50:47 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 22:52:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5c9128c3d52b14e61e822799633...

Powered by Google App Engine
This is Rietveld 408576698