Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2679403004: Remove flaky expectation for http/tests/inspector/search/source-frame-replace-2.html (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
yhirano
CC:
blink-reviews, bokan, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove flaky expectation for http/tests/inspector/search/source-frame-replace-2.html This change was made with Tools/Scripts/TestExpectations, which proposed removing lines for the following tests: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual/threaded/printing/offscreencanvas-2d-printing.html,virtual/threaded/printing/offscreencanvas-webgl-printing.html,http/tests/inspector/search/source-frame-replace-2.html,http/tests/media/video-play-stall.html I decided to just remove the flaky expectation for this one test for now, since the failures for the other tests may be not too far in the past; the tests may still be flaky. BUG=678488 Review-Url: https://codereview.chromium.org/2679403004 Cr-Commit-Position: refs/heads/master@{#449161} Committed: https://chromium.googlesource.com/chromium/src/+/c33888d40c74c5568c85d4c8228831c70d7a7442

Patch Set 1 #

Patch Set 2 : Add back all expectations except one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
3 years, 10 months ago (2017-02-08 20:56:00 UTC) #3
yhirano
On 2017/02/08 20:56:00, qyearsley wrote: Note: the associated virtual/mojo-loading entry was removed in https://chromium.googlesource.com/chromium/src.git/+/b034403ab50b3a27bda35d6cf72efec57f2f1217.
3 years, 10 months ago (2017-02-09 00:29:47 UTC) #8
yhirano
lgtm
3 years, 10 months ago (2017-02-09 00:30:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679403004/20001
3 years, 10 months ago (2017-02-09 00:35:06 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 00:41:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c33888d40c74c5568c85d4c82288...

Powered by Google App Engine
This is Rietveld 408576698