Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2679383002: Add TEAM/COMPONENT (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, cbentzel+watch_chromium.org, James Su, yusukes+watch_chromium.org, nona+watch_chromium.org, rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, blink-reviews, shuchen+watch_chromium.org, net-reviews_chromium.org, mathp+autofillwatch_chromium.org, bnc+watch_chromium.org, rogerm+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, kinuko+watch, abarth-chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TEAM/COMPONENT BUG=679905 Review-Url: https://codereview.chromium.org/2679383002 Cr-Commit-Position: refs/heads/master@{#450040} Committed: https://chromium.googlesource.com/chromium/src/+/5c559e67fb9d48983bdf2ffcaebd7dce11ccb9bc

Patch Set 1 #

Total comments: 48

Patch Set 2 : update team/compo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M chrome/browser/autocomplete/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/google/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/infobars/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/omnibox/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/search_engines/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/infobars/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/google/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/infobars/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/omnibox/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/search_engines/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/test/data/web_database/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/toolbar/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/url_formatter/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/webdata/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/webdata_services/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/registry_controlled_domains/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/libpng/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/protobuf/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/native_theme/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-07 23:19:02 UTC) #2
Peter Kasting
https://codereview.chromium.org/2679383002/diff/1/chrome/browser/autocomplete/OWNERS File chrome/browser/autocomplete/OWNERS (right): https://codereview.chromium.org/2679383002/diff/1/chrome/browser/autocomplete/OWNERS#newcode5 chrome/browser/autocomplete/OWNERS:5: # COMPONENT: UI>Browser UI>Browser>Omnibox https://codereview.chromium.org/2679383002/diff/1/chrome/browser/google/OWNERS File chrome/browser/google/OWNERS (right): https://codereview.chromium.org/2679383002/diff/1/chrome/browser/google/OWNERS#newcode3 ...
3 years, 10 months ago (2017-02-08 00:31:06 UTC) #3
scroggo_chromium
https://codereview.chromium.org/2679383002/diff/1/third_party/WebKit/Source/platform/image-decoders/OWNERS File third_party/WebKit/Source/platform/image-decoders/OWNERS (right): https://codereview.chromium.org/2679383002/diff/1/third_party/WebKit/Source/platform/image-decoders/OWNERS#newcode6 third_party/WebKit/Source/platform/image-decoders/OWNERS:6: # TEAM: paint-dev@chromium.org I don't think this is the ...
3 years, 10 months ago (2017-02-08 14:00:30 UTC) #5
ymzhang1
https://codereview.chromium.org/2679383002/diff/1/chrome/browser/autocomplete/OWNERS File chrome/browser/autocomplete/OWNERS (right): https://codereview.chromium.org/2679383002/diff/1/chrome/browser/autocomplete/OWNERS#newcode5 chrome/browser/autocomplete/OWNERS:5: # COMPONENT: UI>Browser On 2017/02/08 00:31:05, Peter Kasting (OOO ...
3 years, 10 months ago (2017-02-09 23:47:57 UTC) #6
scroggo_chromium
image-decoders and libpng lgtm
3 years, 10 months ago (2017-02-10 15:14:57 UTC) #7
urvang
image-decoders LGTM
3 years, 10 months ago (2017-02-10 21:53:09 UTC) #8
urvang
image-decoders LGTM
3 years, 10 months ago (2017-02-10 21:53:10 UTC) #9
Noel Gordon
image-decoders LGTM
3 years, 10 months ago (2017-02-11 01:39:55 UTC) #10
Peter Kasting
LGTM
3 years, 10 months ago (2017-02-11 04:36:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2679383002/20001
3 years, 10 months ago (2017-02-13 17:41:22 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 19:29:42 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5c559e67fb9d48983bdf2ffcaebd...

Powered by Google App Engine
This is Rietveld 408576698